-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version out of sync with DOC.md #32
Comments
Hi! Thanks for the interest in the library. I haven't had much time those last few months to work on it because I am also teaching in addition to my day job. Any help to drive this library further is appreciated! |
Sure. If I can help, I will :-) But a thought on the onEntityAdded. Why is that a property on the Query? Seems dangerous, since different systems could set it, and they would override it? |
Yeah it's indeed an issue. It should at least be an array of callbacks or something. |
Not quite sure what you mean with the last part. What I like about ecsy, for example is the way you define query additions and removals. It looks like this:
the same way, that execute looks. Internally, the query managers are (or have) event dispatcher, that triggers events for query-relevant items. It also makes for a nicer and more congruent API. |
Yes I see what you mean. I actually double checked my code, I wrote it a long back: ecstra/src/internals/query-manager.ts Line 56 in 7d380fb
So basically it's pretty close to what Ecsy does. What I need is to have an array of listeners instead of overriding the callback, and then we can just rename |
The DOC.md is mentioning some nice and useful features, that the version I got from NPM (0.0.2) does not seem to have, like
seems not to be defined. Also there are some other changes to the NPM version, like different names of decorators.
When is it coming out?
I just switched from ecsy to ecstra. And I like it so far :-)
Need some help? I plan to build my next game with ecstra, if that works out. :-)
The text was updated successfully, but these errors were encountered: