Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pathlib in readers #577

Open
p1003 opened this issue Sep 22, 2022 · 0 comments
Open

Add support for pathlib in readers #577

p1003 opened this issue Sep 22, 2022 · 0 comments

Comments

@p1003
Copy link
Contributor

p1003 commented Sep 22, 2022 •
edited
Loading 

path = Path("some/path")
fromfile(path)

Code above causes file_has_sh_magic_number function from pymchelper/readers/shieldhit/general.py to throw error below.
image

It is desired to work as fine as it works with code below:

path = Path("some/path")
fromfile(str(path))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p1003