Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports via main button don't include orphans #4296

Open
hannes-ucsc opened this issue Nov 29, 2024 · 0 comments · May be fixed by #4306
Open

Exports via main button don't include orphans #4296

hannes-ucsc opened this issue Nov 29, 2024 · 0 comments · May be fixed by #4306
Assignees
Labels
canary Done by the Clever Canary team

Comments

@hannes-ucsc
Copy link
Member

#4254 solved the inclusion of orphans for an export of a single dataset from the Export tab of the dataset details page.

DataBiosphere/azul#6728 enhanced Azul to include orphans when filtering exclusively by dataset properties. With that enhancement, Azul now includes orphans when filtering by datasets.title, for example, as long as no filters for properties of entities of other types are present.

When the user clicks the Export button on the top right of the UI, and selects all file and organism types, Data Browser unnecessarily specifies filters for file and organism types even if the user selects all possible types, in which case the filters are redundant. Filtering by every possible value of a facet is equivalent to not filtering by that facet at all.

The presence of these redundant filters defeats Azul's detection of the fact that a manifest for an entire dataset is being requested, and causes it to exclude orphans from that manifest.

For example, the manifest request currently made by the Data Browser is

https://service.anvil.gi.ucsc.edu/fetch/manifest/files?catalog=anvil&filters={"datasets.title":{"is":["ANVIL_1000G_2019_Dev"]},"donors.organism_type":{"is":[null]},"files.file_format":{"is":[".md5",".tbi",".vcf.gz",".crai",".cram",".txt"]}}&format=verbatim.pfb

In order to include orphans, that request would have to read

https://service.anvil.gi.ucsc.edu/fetch/manifest/files?catalog=anvil&filters={"datasets.title":{"is":["ANVIL_1000G_2019_Dev"]}}&format=verbatim.pfb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants