Add ME HAP disable option to Protectli platforms #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipandag
force-pushed
the
add-me-hap-disable-protectli
branch
from
cc9ed57 to
ad1b97e
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
miczyg1
force-pushed
the
add-me-hap-disable-protectli
branch
from
e3e1ef0 to
a008e47
Compare
|
I also pushed a commit to disable HECI if ME is in any disabled mode to match the behavior of other platforms. I did it only for Elkhart Lake and Meteor Lake where the FSP is known to leave HECI enabled in such cases. @mkopec cc, want to look at it as well? |
miczyg1
previously approved these changes
Nov 29, 2024
miczyg1
force-pushed
the
add-me-hap-disable-protectli
branch
from
a008e47 to
ce0dc83
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
miczyg1
force-pushed
the
add-me-hap-disable-protectli
branch
from
ce0dc83 to
be6ead1
Compare
miczyg1
previously approved these changes
Nov 29, 2024
…bled mode Disable/hdie HECI if ME is in debug/HAP or soft disabled mode. The HECI should be hidden if ME is disabled using HAP or HECI message. Match the behavior of other platforms which disable HECI in FSP. Signed-off-by: Michał Żygowski <[email protected]>
miczyg1
force-pushed
the
add-me-hap-disable-protectli
branch
from
be6ead1 to
609e958
Compare
miczyg1
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.