[MSI] Add STM defconfigs #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I973f411f53726952d159560c6810e3a22ac38c4e Signed-off-by: Michał Kopeć <[email protected]>
Change-Id: I0365d58d48c84a5f21103fb31f6313200c93858c Signed-off-by: Michał Kopeć <[email protected]>
Add defconfigs for STM. These configs use vboot rwa layout in order to fit the STM binaries. Change-Id: Ifb5c767283b4abfccfc14a459669bd83a2d84fe4 Signed-off-by: Michał Kopeć <[email protected]>
|
@mkopec thanks, I will ask Brian to try them out. |
mkopec
force-pushed
the
msi_rwa
branch
2 times, most recently
from
9f22b73 to
30d3ffe
Compare
Change-Id: I9402b52f8f4c293ed0f1fd3e0e76307ca19b2b27 Signed-off-by: Michał Kopeć <[email protected]>
Change-Id: I62d059777fbc6d435f278517c0a13ff68d849893 Signed-off-by: Michał Kopeć <[email protected]>
|
Thanks! This solved the problem with fitting the stm.bin into the CBFS volume. For the fully-working STM support, the default values in the configs files will need to be changed but I can advise on that once I conclude that testing. But for the concern of fitting the stm.bin image, these changes resolve the space constraint. Attaching a sample log from testing. (Can 'grep -i stm' for the STM-relevant portions.) Also, recovery with MSI FlashBack still worked for me using this PR so that was good to see. |
krystian-hebel
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add STM defconfigs which use vboot in rwa configuration (no slot B) in order to make space for the STM binaries. Bootsplash region was moved as well to make the RW_A and WP_RO slots more equal in size. Make sure the ROMHOLE region is at the correct offset to ensure that BIOS flashback still works.