Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't want the internet permission #12

Open
serrq opened this issue Jul 27, 2024 · 11 comments
Open

I don't want the internet permission #12

serrq opened this issue Jul 27, 2024 · 11 comments

Comments

@serrq
Copy link

serrq commented Jul 27, 2024

Might you adding the groceries list package in Github download section?

Or including it directly in the apk.

@vdbhb59
Copy link

vdbhb59 commented Jul 28, 2024

The list is available here: assets/product
Though I agree it seems to be calling it.
assets/product/default_products_en.json
assets/product/default_products_change_list.json

@DanielRendox
Copy link
Owner

@serrq Hmm, interesting.

Including it in the apk is not an option since I'd want to add real time grocery list sharing in the future.

It currently downloads the list from GitHub on first install. But it is also set up to update the local version once any additional groceries or icons are added. This way, there is no need to ship a new version just to add some more groceries.

However, without an internet permission users will need to do all of that manually. 🤔

@serrq
Copy link
Author

serrq commented Jul 29, 2024

without an internet permission users will need to do all of that manually.

Just add an URL in app to link to download file in Github. Push it and it open an external browser page. That's it.

@vdbhb59
Copy link

vdbhb59 commented Jul 29, 2024

Or better, allow upload via a file. That way there is no need for the app itself to connect to internet. Just upload and set in tables.

@serrq
Copy link
Author

serrq commented Jul 29, 2024

I already downloaded the file through Github.

Wait for upload via file feature in next versions. Or I change app target.

@serrq
Copy link
Author

serrq commented Jul 29, 2024

Currently the file is something.txt. We can renaming it in .bin once downloaded if needed.

@serrq
Copy link
Author

serrq commented Jul 29, 2024

@vdbhb59 I mean a copyable URL (in app) in order to suggest to non-tech savvy people where is this damned file.

An user can paste it where it wants (its browser).

@vdbhb59
Copy link

vdbhb59 commented Jul 29, 2024

"Damned file" lol, nice one mate.

No I knew what you meant. I offered an alternate solution, as trust me people unlike tech savvy would love to download files (I can show you same file downloaded several times, lols, and they still download it over and over again. But yes, link sounds much better.
On more suggestion is, provide the option to download/use the file. Honestly, a lot of those items in the list are generic, or only for European end of items + non-veg is included as well.
The way to get things can increase the code base as well. The best approach is either via a link or upload functionality. Link probably wold require curl/wget logic, manual upload would increase the code base as well.

Just my thoughts. :)

@vdbhb59
Copy link

vdbhb59 commented Jul 29, 2024

Another thought is: Can this connection to internet be a one time activity, post which the permission is automatically revoked, or can be revoked by user in some manner?

@serrq
Copy link
Author

serrq commented Jul 29, 2024

There is no revoke toggle for internet permission, currently. In Android, I mean.

@vdbhb59
Copy link

vdbhb59 commented Jul 29, 2024

There is no revoke toggle for internet permission, currently. In Android, I mean.

Yeah, I thought so. Was not sure, so thought of putting it here as an ask as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants