From 9893b736a88be6b95c82a04b118fc03c228759a3 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Thu, 16 Jan 2025 16:16:57 +0100 Subject: [PATCH] Tidy up comments LBM (#2231) --- src/equations/lattice_boltzmann_2d.jl | 8 -------- src/equations/lattice_boltzmann_3d.jl | 8 -------- src/solvers/dgsem_tree/dg_2d.jl | 2 +- src/solvers/dgsem_tree/dg_2d_parabolic.jl | 2 +- 4 files changed, 2 insertions(+), 18 deletions(-) diff --git a/src/equations/lattice_boltzmann_2d.jl b/src/equations/lattice_boltzmann_2d.jl index b2323789ddb..45184b7a70b 100644 --- a/src/equations/lattice_boltzmann_2d.jl +++ b/src/equations/lattice_boltzmann_2d.jl @@ -235,9 +235,6 @@ No-slip wall boundary condition using the bounce-back approach. return flux end -# Pre-defined source terms should be implemented as -# function source_terms_WHATEVER(u, x, t, equations::LatticeBoltzmannEquations2D) - # Calculate 1D flux in for a single point @inline function flux(u, orientation::Integer, equations::LatticeBoltzmannEquations2D) if orientation == 1 @@ -248,11 +245,6 @@ end return v_alpha .* u end -# Calculate maximum wave speed for local Lax-Friedrichs-type dissipation -# @inline function max_abs_speed_naive(u_ll, u_rr, orientation::Integer, equations::LatticeBoltzmannEquations2D) -# λ_max = -# end - """ flux_godunov(u_ll, u_rr, orientation, equations::LatticeBoltzmannEquations2D) diff --git a/src/equations/lattice_boltzmann_3d.jl b/src/equations/lattice_boltzmann_3d.jl index 2211ac5bb71..017e0f07fc7 100644 --- a/src/equations/lattice_boltzmann_3d.jl +++ b/src/equations/lattice_boltzmann_3d.jl @@ -223,9 +223,6 @@ function initial_condition_constant(x, t, equations::LatticeBoltzmannEquations3D return equilibrium_distribution(rho, v1, v2, v3, equations) end -# Pre-defined source terms should be implemented as -# function source_terms_WHATEVER(u, x, t, equations::LatticeBoltzmannEquations3D) - # Calculate 1D flux in for a single point @inline function flux(u, orientation::Integer, equations::LatticeBoltzmannEquations3D) if orientation == 1 # x-direction @@ -238,11 +235,6 @@ end return v_alpha .* u end -# Calculate maximum wave speed for local Lax-Friedrichs-type dissipation -# @inline function max_abs_speed_naive(u_ll, u_rr, orientation::Integer, equations::LatticeBoltzmannEquations3D) -# λ_max = -# end - """ flux_godunov(u_ll, u_rr, orientation, equations::LatticeBoltzmannEquations3D) diff --git a/src/solvers/dgsem_tree/dg_2d.jl b/src/solvers/dgsem_tree/dg_2d.jl index 98bd0889206..118b1f75bb8 100644 --- a/src/solvers/dgsem_tree/dg_2d.jl +++ b/src/solvers/dgsem_tree/dg_2d.jl @@ -1118,7 +1118,7 @@ end # @views mul!(surface_flux_values[v, :, direction, large_element], # mortar_l2.reverse_upper, fstar_upper[v, :]) # @views mul!(surface_flux_values[v, :, direction, large_element], - # mortar_l2.reverse_lower, fstar_lower[v, :], true, true) + # mortar_l2.reverse_lower, fstar_lower[v, :], true, true) # end # The code above could be replaced by the following code. However, the relative efficiency # depends on the types of fstar_upper/fstar_lower and dg.l2mortar_reverse_upper. diff --git a/src/solvers/dgsem_tree/dg_2d_parabolic.jl b/src/solvers/dgsem_tree/dg_2d_parabolic.jl index 2123eae5459..ce14da8d205 100644 --- a/src/solvers/dgsem_tree/dg_2d_parabolic.jl +++ b/src/solvers/dgsem_tree/dg_2d_parabolic.jl @@ -725,7 +725,7 @@ end # @views mul!(surface_flux_values[v, :, direction, large_element], # mortar_l2.reverse_upper, fstar_upper[v, :]) # @views mul!(surface_flux_values[v, :, direction, large_element], - # mortar_l2.reverse_lower, fstar_lower[v, :], true, true) + # mortar_l2.reverse_lower, fstar_lower[v, :], true, true) # end # The code above could be replaced by the following code. However, the relative efficiency # depends on the types of fstar_upper/fstar_lower and dg.l2mortar_reverse_upper.