New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review - Check code for oddities, improvements, inconsistencies, bugs, ... #13

Open

DacoTaco opened this issue Jun 12, 2022 · 0 comments

Owner

DacoTaco commented Jun 12, 2022 •

edited

Loading

Mostly reported by DeltaV :

check why syscall instructions lose parameters somewhere down the line
check write32 in pll setup. maybe use set32 or mask
fix undefined asm -> remove bic & ifdef
fix svc asm -> ldr, #-1 and pass only character? can we remove the bic that way?

DacoTaco added this to StarStruck

DacoTaco moved this to Todo in StarStruck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment