Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 1.x docker #56

Merged
merged 20 commits into from
Dec 28, 2022
Merged

Feat 1.x docker #56

merged 20 commits into from
Dec 28, 2022

Conversation

nankaNULL
Copy link
Contributor

@nankaNULL nankaNULL commented Dec 28, 2022

提交的变更类型是

  • 添加新功能
  • 修复 bug
  • 优化代码风格
  • 代码重构
  • 增加单元测试
  • 增加依赖库/工具

相关链接

issue: #5

需求描述和解决方案

描述

  1. 添加 Dockerfile,支持创建 Doraemon web 镜像和 mysql 镜像
  2. 添加镜像构建脚本和启动脚本
  3. 添加 process.env.DEPLOY_ENV,配合 env.json 的 docker 配置一起使用
  4. 补充帮助文档

解决方案

自查清单

  • 代码遵循这个项目的风格指南
  • 对代码进行了自我审查
  • 已经在难以理解的代码处做了相关注释
  • 更改不会产生新的警告
  • 任何依赖更改都已合并并发布在下游模块中

@nankaNULL nankaNULL requested a review from liuxy0551 December 28, 2022 05:56
@@ -0,0 +1,10 @@
#!/bin/bash
export image_mysql=172.16.84.121/dtstack-dev/doraemon_mysql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip 写到文档里,不要写到代码里

sql/doraemon.sql Outdated
@@ -36,9 +36,9 @@ CREATE TABLE `app_centers` (
`status` int DEFAULT '1',
`clickCount` int DEFAULT '0',
PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=49 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AUTO_INCREMENT 的值改不改无所谓的吧

@liuxy0551 liuxy0551 merged commit 434dcfa into dev Dec 28, 2022
@liuxy0551 liuxy0551 deleted the feat_1.x_docker branch May 17, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants