Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][chunjun-connectors] jdbc's properties not work where jdbc's reader has set properties #1880

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

AliceXiaoLu
Copy link
Contributor

…der has set properties

Purpose of this pull request

Which issue you fix

Fixes # (issue).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@github-actions github-actions bot added the CORE label Feb 21, 2024
@AliceXiaoLu
Copy link
Contributor Author

@chenzhuangjia fix this--#1874

@AliceXiaoLu
Copy link
Contributor Author

@zoudaokoulife fix this--#1874 , 已重新提交

@github-actions github-actions bot removed the CORE label Feb 23, 2024
@AliceXiaoLu
Copy link
Contributor Author

@zoudaokoulife please review again, Thanks again.

@yanghuaiGit yanghuaiGit merged commit 33c14a5 into DTStack:master Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants