Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ng-dynamic-forms v15 and rxjs v7 #1590

Closed
tdonohue opened this issue Apr 8, 2022 · 0 comments · Fixed by #1615
Closed

Update to ng-dynamic-forms v15 and rxjs v7 #1590

tdonohue opened this issue Apr 8, 2022 · 0 comments · Fixed by #1615
Assignees
Labels
bug dependencies Pull requests that update a dependency file e/8 Estimate in hours high priority
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented Apr 8, 2022

Description

Discovered in #1567. There's a newer version of ng-dynamic-forms available to support Angular 13. However, it requires also upgrading to rxjs v7.

@ybnd analyzed the effort here and noted:

  • Upgrading only rxjs to v7 results in ~200 test failures, a good number of which fail due pretty uninformatively within rxjs code, no DSpace in the trace at all -- this will take me a while to figure out
  • ng-dynamic-forms@15 depends on rxjs@7, so it would be best to do both at the same time
  • When upgrading both, as well as other mismatched peer dependencies that come up ~ rxjs@7 reduces the amount of failing tests to 11, so it would definitely be more manageable to upgrade all of these at once.

Estimated at 8hrs by @artlowel

Related work
Follow-up work for #1567

@tdonohue tdonohue added bug dependencies Pull requests that update a dependency file high priority e/8 Estimate in hours labels Apr 8, 2022
@tdonohue tdonohue added this to the 7.3 milestone Apr 8, 2022
@tdonohue tdonohue mentioned this issue Apr 8, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file e/8 Estimate in hours high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants