Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty Interaction description for Exchange Item #35

Open
ewuerger opened this issue Sep 16, 2024 · 0 comments
Open

Faulty Interaction description for Exchange Item #35

ewuerger opened this issue Sep 16, 2024 · 0 comments

Comments

@ewuerger
Copy link
Member

The template for Logical and SW interfaces are problematic in regards to the allocated_functional_exchanges table:

{% for exchange in object.allocated_functional_exchanges %}
<tr>
<td><a href="{{ exchange | make_href }}">{{ "LEXC-" + exchange.uuid[:5] | upper }}</a></td>
<td>
{{ describe_exchange(exchange) | safe }}
{% if exchange.exchange_items %}
{% if exchange.exchange_itemslength > 1 %}
<p>{{ exchange.name }} is further specified via the following Exchange Items:</p>
<ul>
{% for item in exchange.exchange_items %}
<li>{{ linked_name(item) | safe }}</li>
{% endfor %}
</ul>
{% else %}
<p>This interaction is further specified via {{ linked_name(exchange.exchange_items[0]) | safe}} Exchange Item</p>
{% endif %}
{% endif %}
</td>
</tr>
{% endfor %}
</table>

  • Both templates use the exact same code (refactor as a macro)
  • In the else case linked_name_with_icon is used and still Exchange Item is written behind it

Suggestion:
Implement an Exchange Item icon in py-capellambse and then remove the Exchange Item from the rendered text in the new macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant