From ecaa87bc2291405cd8bbef55ac48b59a9c39eea6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Stromsk=C3=BD?= <jakub@dnastack.com>
Date: Mon, 29 Jul 2024 17:25:58 +0200
Subject: [PATCH] [CU-86b1a2uaj] Update probes so they meet our needs (#53)

- remove readiness probe as app can accept traffic right after startup
- add startup probe
- update liveness probe to reasonable values
---
 helm/templates/deployment.yaml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/helm/templates/deployment.yaml b/helm/templates/deployment.yaml
index 8bf8c89..7adbd18 100644
--- a/helm/templates/deployment.yaml
+++ b/helm/templates/deployment.yaml
@@ -177,22 +177,23 @@ spec:
               memory: {{ .Values.app.memoryLimit }}
             requests:
               memory: {{ .Values.app.memoryLimit }}
-          readinessProbe:
+          startupProbe:
             httpGet:
               path: /actuator/health
               port: 8080
               scheme: HTTP
             initialDelaySeconds: 10
-            periodSeconds: 5
-            timeoutSeconds: 120
+            periodSeconds: 10
+            timeoutSeconds: 2
+            failureThreshold: 18 # this will result in a 3 minutes timeout (periodSeconds * failureThreshold)
           livenessProbe:
             httpGet:
               path: /actuator/health
               port: 8080
               scheme: HTTP
-            initialDelaySeconds: 30
             periodSeconds: 10
-            timeoutSeconds: 10
+            timeoutSeconds: 2
+            failureThreshold: 1
           env:
             - name: JAVA_OPTS
               value: "-XX:+PrintFlagsFinal -XX:+ExitOnOutOfMemoryError"