Fix: Update coverage action to trigger on (un)labeled events #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-cosma
force-pushed
the
actions/fix-on-label
branch
from
fda2ad8 to
e3b113c
Compare
Signed-off-by: George Cosma <[email protected]>
george-cosma
force-pushed
the
actions/fix-on-label
branch
from
fa2203d to
78cdbd8
Compare
|
I've fixed the issue highlighted in the |
wucke13
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes an issue in the coverage PR preview workflow. Previously, if the PR was labeled then the preview would only deploy if a commit was made. More so, removing the designated label only disabled new updates, but did not remove the old coverage report.
Testing Strategy
This pull request was tested on george-cosma#6. See the comments.
TODO or Help Wanted
This pull request still has an issue: If thecoveragelabel is applied AND if the user labels/unlabels a PR with any other label, then the workflow will run the coverage check, but will not deploy.Formatting
cargo fmtcargo checkcargo buildcargo docnix fmttreefmtGithub Issue
This pull request helps close #45