fix: per module sidetables #118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will probably have to be rewritten when the linker is merged in. what "current" sidetable is will still need to be held in the call stack, as we need to remember which module the caller was in, and if we call or return from a different module, we'll need to update the current sidetable. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
Is there a specific reason why we want to do this? Genuinely curious |
Signed-off-by: Cem Onem <[email protected]>
cemonem
force-pushed
the
dev/cemonem-per-module-sidetable
branch
from
ba3028f to
6076956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
per module sidetables instead of per function, sidetables are stored within the Store object.
Formatting
cargo fmtcargo checkcargo buildcargo docnix fmtGithub Issue
This pull request closes #115