Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-attaching of devices #80

Closed
wucke13 opened this issue Jul 14, 2023 · 1 comment
Closed

re-attaching of devices #80

wucke13 opened this issue Jul 14, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@wucke13
Copy link
Contributor

wucke13 commented Jul 14, 2023

Maybe we can eventually build something where for each partition with at least one device mount we run udevadm wait --settle <device> [<device>]... in a satellite thread, and we re-mount the device when it re-appears back. That way we can re-attach a device without restarting the hypervisor, for example if a USB connection got reset temporarily due to electromagnetic disturbances.

@wucke13 wucke13 added the enhancement New feature or request label Jul 14, 2023
wucke13 added a commit that referenced this issue Jul 14, 2023
This field was not used at all in the codebase, having it in the config
is misleading. Further on, it seems that there is no point in having it:
device files can be mounted through the mount option already.

Maybe we can eventually build something where for each partition
with at least one device mount we run `udevadm wait --settle <device>
[<device>]...` in a satellite thread, and we re-mount a device when it
pops back. That way we can re-attach a device without restarting the
hypervisor.

Further discussion in #80
sevenautumns pushed a commit that referenced this issue Jul 19, 2023
* add dev_random example

This example illustrates how to use the mount option on partitions.

* remove device field from the partition config

This field was not used at all in the codebase, having it in the config
is misleading. Further on, it seems that there is no point in having it:
device files can be mounted through the mount option already.

Maybe we can eventually build something where for each partition
with at least one device mount we run `udevadm wait --settle <device>
[<device>]...` in a satellite thread, and we re-mount a device when it
pops back. That way we can re-attach a device without restarting the
hypervisor.

Further discussion in #80

* refine CI, add prettier

---------

Co-authored-by: Wanja Zaeske <[email protected]>
@wucke13
Copy link
Contributor Author

wucke13 commented Mar 12, 2024

Commit 53bb05e removes the device filed, thus rendering this issue invalid

@wucke13 wucke13 added the wontfix This will not be worked on label Mar 12, 2024
@wucke13 wucke13 closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants