Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nitpick Collection #38

Closed
sevenautumns opened this issue Jan 24, 2023 · 1 comment · Fixed by #40
Closed

Nitpick Collection #38

sevenautumns opened this issue Jan 24, 2023 · 1 comment · Fixed by #40
Assignees
@cvengler
Labels
good first issue Good for newcomers

Comments

@sevenautumns
Copy link
Collaborator

sevenautumns commented Jan 24, 2023 •
edited
Loading

https://github.com/aeronautical-informatics/apex-linux/blob/76dee04a764113fc9a2eae371972faeac598556b/core/src/cgroup.rs#L172-L179 Use for range instead

https://github.com/aeronautical-informatics/apex-linux/blob/76dee04a764113fc9a2eae371972faeac598556b/core/src/cgroup.rs#L88-L91 Return error instead of unwrapping

https://github.com/aeronautical-informatics/apex-linux/blob/76dee04a764113fc9a2eae371972faeac598556b/partition/src/apex.rs#L155-L159 Use ok_or_else with ? instead
@sevenautumns sevenautumns added the good first issue Good for newcomers label Jan 24, 2023
@cvengler
Copy link
Member

I doubt that the latter one is what you want, because read is of type Result<T, E> and not Option<T>

cvengler added a commit that referenced this issue Jan 26, 2023
@cvengler
core: replace while loop with for loop
459c88c 
Fixes #38
@cvengler cvengler mentioned this issue Jan 26, 2023
Merged
sevenautumns pushed a commit that referenced this issue Jan 26, 2023
@cvengler @sevenautumns
core: replace while loop with for loop
cf17bb1 
Fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvengler cvengler

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: replace while loop with for loop DLR-FT/a653rs-linux
2 participants
@cvengler @sevenautumns