Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up object serialization API #11

Open
MaddieM4 opened this issue Aug 15, 2014 · 1 comment
Open

Clean up object serialization API #11

MaddieM4 opened this issue Aug 15, 2014 · 1 comment

Comments

@MaddieM4
Copy link
Member

There's a bit of awkwardly duplicated code in document.serialize and event.serialize. Both of them should, ideally, accept a format object and pass it on to utils.serialize.

Will also need changes to the test suite.

@MaddieM4
Copy link
Member Author

Another, very valid option is to remove the per-object convenience functions (which are somewhat redundant) and simply use the Utils.serialize function. I actually kinda prefer this, since it will also make it more consistent to serialize arbitrary objects in the serialization test suite in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant