754 les onglets ne sont plus sticky quand on change de route #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bellangerq
approved these changes
Jul 10, 2024
hissalht
reviewed
Jul 10, 2024
Comment on lines
160
to
171
| onMounted(async () => { | ||
| const el = await waitForElement("#sticky-indicator"); | ||
| const resizeObserver = new ResizeObserver((entries) => { | ||
| stickyTop.value = entries[0].target.clientHeight + "px"; | ||
| // Because auditGenerationHeader ref is inside a "v-if", | ||
| // Vue will not instantiate the ref immediately. | ||
| // We need to watch it before observing nested stickyIndicator | ||
| watch(auditGenerationHeader, async () => { | ||
| const stickyIndicator = auditGenerationHeader.value?.stickyIndicator; | ||
| resizeObserver = new ResizeObserver((entries) => { | ||
| stickyTop.value = entries[0].target.clientHeight + "px"; | ||
| }); | ||
| stickyIndicator && resizeObserver.observe(stickyIndicator); | ||
| }); | ||
| resizeObserver.observe(el); | ||
| }); |
There was a problem hiding this comment.
On a le "droit" de mettre un watch dans un onMounted ?
There was a problem hiding this comment.
Bien vu @hissalht . Je pense que c’est permis, mais clairement inutile et ça devait surement créer un memory leak.
Voir : https://vuejs.org/guide/essentials/watchers#stopping-a-watcher
J’ai simplement enlevé le onMounted pour ne laisser que le watch.
Voir 5856a49.
|
Nickel pour l'ajustement entre le composant "ajout de fichier" et "l'impact usager". En revanche, j'ai noté deux petites choses (je ne sais pas à quoi c'est dû) :
|
|
@AdrienMuzyczka :
|
Ça marche :) |
yaaax
force-pushed
the
754-les-onglets-ne-sont-plus-sticky-quand-on-change-de-route
branch
from
dc91341 to
d0bd5af
Compare
* expose stickyIndicator from AuditGenerationHeader * watch for ref updates in AuditGenerationPage Note that nested stickyIndicator height is used with 2 sticky divs: filters and tabs
yaaax
force-pushed
the
754-les-onglets-ne-sont-plus-sticky-quand-on-change-de-route
branch
from
d0bd5af to
5c40cf8
Compare
yaaax
force-pushed
the
754-les-onglets-ne-sont-plus-sticky-quand-on-change-de-route
branch
from
8f8d04e to
5856a49
Compare
yaaax
deleted the
754-les-onglets-ne-sont-plus-sticky-quand-on-change-de-route
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.