Hide dropdown menu instead of removing it from DOM #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perso pas de problème avec ça. |
bellangerq
approved these changes
Nov 20, 2024
| :id="`dropdown-${uniqueId}`" | ||
| :hidden="!showContent" | ||
| :class="[ | ||
| { 'fr-hidden': !showContent }, |
There was a problem hiding this comment.
Besoin de doubler l'attribut hidden avec une classe ?
There was a problem hiding this comment.
En effet, inutile ici, j’ai supprimé ;)
Merci !
yaaax
force-pushed
the
880-code-html-non-valide-avant-ouverture-le-menu-télécharger-est-référencé-par-son-bouton-mais-nest-pas-présent-dans-le-dom
branch
from
58bdf55 to
ed437b3
Compare
yaaax
force-pushed
the
880-code-html-non-valide-avant-ouverture-le-menu-télécharger-est-référencé-par-son-bouton-mais-nest-pas-présent-dans-le-dom
branch
from
ed437b3 to
856267f
Compare
Note: no more smooth transition after this change
yaaax
force-pushed
the
880-code-html-non-valide-avant-ouverture-le-menu-télécharger-est-référencé-par-son-bouton-mais-nest-pas-présent-dans-le-dom
branch
from
856267f to
89dcdd2
Compare
yaaax
deleted the
880-code-html-non-valide-avant-ouverture-le-menu-télécharger-est-référencé-par-son-bouton-mais-nest-pas-présent-dans-le-dom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: no more smooth transition after this change