Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player permissions to delete/disable effect #49

Open
tirzah2 opened this issue Aug 20, 2023 · 4 comments
Open

player permissions to delete/disable effect #49

tirzah2 opened this issue Aug 20, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request tracked Issue created in separate board

Comments

@tirzah2
Copy link

tirzah2 commented Aug 20, 2023

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Add the feature of making it impossible for players to delete or disable effects from the dfred effect panel

Additional context
In the settings is possible to choose who can see the panels but not a setting of who can actually interact with it. I would like the players to be able to see the effects and read the descriptions, but not be able to deactive them or delete them.

@tirzah2 tirzah2 added the enhancement New feature or request label Aug 20, 2023
@DFreds
Copy link
Owner

DFreds commented Sep 26, 2023

This goes beyond the scope of this module. If a player has ownership access to their character, then they can easily delete or disable effects even without this module. There might be an existing module that allows this, but I won't be supporting it in this one.

@DFreds DFreds closed this as completed Sep 26, 2023
@Ancyker
Copy link

Ancyker commented Feb 20, 2024

This goes beyond the scope of this module. If a player has ownership access to their character, then they can easily delete or disable effects even without this module.

@DFreds My games contain new players and players that are not tech-savvy, so I don't like that they can easily disable or delete an effect via something that is always on their screen, possibly without even realizing it. I came here to make this same request. This is in line with the same reason that having a lock on the character sheet is such a nice option.

If you absolutely refuse to add an option to just make clicking do nothing, then could you at least add an option so that clicking only opens the character sheet with the effects tab active (or switches to the tab if already open) or something? Session time is precious and I'd rather not be spending it constantly fixing people's character sheets because of a stray mouse click and/or an impulsive selection on a dialog.

This along with the ability to set the offset and size of the icons is why I've been sticking to Visual Active Effects, even though I like the hover tooltips of this module a little better.

@DFreds
Copy link
Owner

DFreds commented Feb 20, 2024

Hm, so I think I initially misunderstood this as not allowing manipulating effects at all, which was out of the scope. I think what you're asking is reasonable. And the icon size. What's the offset you're talking about?

@DFreds DFreds reopened this Feb 20, 2024
@DFreds DFreds added the tracked Issue created in separate board label Feb 20, 2024
@Ancyker
Copy link

Ancyker commented Feb 21, 2024

What's the offset you're talking about?

It's how far away the icons start from the top of the screen/canvas, it could be done with CSS probably but it's nice to have an actual setting for it. I have the "Heartbeat" module and some other modules that also put things on the top right, so having a "Top Offset" that lets me specify the number of pixels to move the icons down is nice. Icon size is also nice as a per-user setting, I made the default for them 25px because, while I play on a 4K monitor, most of my players have a 1080p monitor. So, for them, the default size can be a bit large/eat up a lot of screen real estate.

If you really want to deep dive into it you could also add options for which side the icons appear on and stuff, but then it becomes harder to make sure they don't overlap things. Like, for that to work for someone with a lot of modules reliably would almost certainly require the use of custom CSS to account for all the modules. Although, I am a bit of an extreme case with 158 active modules 😅. Other options could include an offset from the side, font size, colors/theme, etc, though that gets into overkill territory.

The only other thing that might be nice is a way to collapse the icons. If you have a lot of effects it can get distracting. Everyone likes throwing buffs at the barbarian and he can end up with 5-10+ temporary effects, lol. I think there are some other QoL things that'd be nice to have but they get a bit niche and definitely would need their own issue/post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracked Issue created in separate board
Projects
None yet
Development

No branches or pull requests

3 participants