Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job.item_category needs to be renamed and retyped #668

Closed
ab9rf opened this issue Oct 4, 2023 · 1 comment
Closed

job.item_category needs to be renamed and retyped #668

ab9rf opened this issue Oct 4, 2023 · 1 comment

Comments

@ab9rf
Copy link
Member

ab9rf commented Oct 4, 2023

this field is both mistyped and misnamed; it's not a stockpile_group_set and is called specflag in toady code

the field encodes multiple overlapping bits depending on job type:

  • bit0: ConstructBuildingSwitchedSpot, CleanPatientTriedSoap, CleanSelfTriedSoap, PlaceTrackVehicleClearedJobs, GatherFromZone, DrinkItemLookedForNearbyGoblet, InterrogationDidOfficeAttempt
  • bit1: GatherPickTrees
  • bit2: GatherPickShrubs
  • bit3: GatherGatherFallen
  • bit4: GatherNoLadderSearch
  • bit5: GatherLadderRestricted
  • bit6: GatherLadderGround

however there are multiple references in code to this field so renaming it requires coordination
@quietust
Copy link
Member

Fixed with b20766d + ee001f2 + 0489c12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quietust @ab9rf