From 69bbf3380c3b74d67432283120e7d847d6d41ed5 Mon Sep 17 00:00:00 2001 From: Richard Lynch Date: Wed, 18 Sep 2024 11:04:31 +0100 Subject: [PATCH] Remove duplicated question This question is the same for all policies so move it to the top level admin namespace --- app/views/admin/tasks/payroll_details.html.erb | 2 +- config/locales/en.yml | 5 +---- spec/features/admin/admin_claim_payroll_details_task_spec.rb | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/app/views/admin/tasks/payroll_details.html.erb b/app/views/admin/tasks/payroll_details.html.erb index 2cbfb1c3bb..3d2c810b45 100644 --- a/app/views/admin/tasks/payroll_details.html.erb +++ b/app/views/admin/tasks/payroll_details.html.erb @@ -49,7 +49,7 @@

<%= I18n.t( - "#{@claim.policy.to_s.underscore}.admin.task_questions.payroll_details.title", + "admin.tasks.payroll_details.question", bank_or_building_society: I18n.t("admin.#{@claim.bank_or_building_society}"), claimant_name: @claim.full_name ) %> diff --git a/config/locales/en.yml b/config/locales/en.yml index 0098cf9546..b73cb8bd95 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -154,6 +154,7 @@ en: title: "Check student loan plan" payroll_details: title: "Check bank/building society account details" + question: "%{claimant_name}'s %{bank_or_building_society} details have not been automatically validated. Has %{claimant_name} confirmed their %{bank_or_building_society} details?" census_subjects_taught: title: "Check eligible subjects are taught" visa: @@ -430,8 +431,6 @@ en: title: "Does the claimant’s student loan amount and plan type match the information we hold about their loan?" matching_details: title: "Is this claim still valid despite having matching details with other claims?" - payroll_details: - title: "%{claimant_name}'s %{bank_or_building_society} details have not been automatically validated. Has %{claimant_name} confirmed their %{bank_or_building_society} details?" additional_payments: &additional_payments forms: correct_school: @@ -671,8 +670,6 @@ en: title: Does the claimant's subject match the schools workforce census subjects matching_details: title: "Is this claim still valid despite having matching details with other claims?" - payroll_details: - title: "%{claimant_name}'s %{bank_or_building_society} details have not been automatically validated. Has %{claimant_name} confirmed their %{bank_or_building_society} details?" reminders: full_name: Full name information_provided_further_details: For more details, you can read about payments and deductions for the %{link} diff --git a/spec/features/admin/admin_claim_payroll_details_task_spec.rb b/spec/features/admin/admin_claim_payroll_details_task_spec.rb index a85e5e2d26..2fb164a423 100644 --- a/spec/features/admin/admin_claim_payroll_details_task_spec.rb +++ b/spec/features/admin/admin_claim_payroll_details_task_spec.rb @@ -34,7 +34,7 @@ click_on I18n.t("admin.tasks.payroll_details.title") expect(page).to have_content I18n.t( - "student_loans.admin.task_questions.payroll_details.title", + "admin.tasks.payroll_details.question", bank_or_building_society: I18n.t("admin.#{claim.bank_or_building_society}"), claimant_name: claim.full_name )