diff --git a/app/models/automated_checks/claim_verifiers/student_loan_plan.rb b/app/models/automated_checks/claim_verifiers/student_loan_plan.rb index 8410da40de..785004510b 100644 --- a/app/models/automated_checks/claim_verifiers/student_loan_plan.rb +++ b/app/models/automated_checks/claim_verifiers/student_loan_plan.rb @@ -65,7 +65,7 @@ def create_task(match:, passed: nil) def note_body(match:) prefix = "[SLC Student loan plan]" - return "#{prefix} - No data" unless match + return "#{prefix} - No matching entry found in the SLC data" unless match if slc_repaying_plan_types "#{prefix} - Matched - has a student loan" diff --git a/app/views/admin/tasks/student_loan_plan.html.erb b/app/views/admin/tasks/student_loan_plan.html.erb index 76ca15dd3e..be68caf4c4 100644 --- a/app/views/admin/tasks/student_loan_plan.html.erb +++ b/app/views/admin/tasks/student_loan_plan.html.erb @@ -24,7 +24,7 @@ <%= task_status_content_tag(status_colour: "grey", status: "Incomplete") %>
- This task has not been checked against Student Loan Company data yet. + No matching entry has been found in the Student Loan Company data yet.
<% end %> diff --git a/spec/features/further_education_payments/student_loan_spec.rb b/spec/features/further_education_payments/student_loan_spec.rb index 35a2b5374e..86e742a0e9 100644 --- a/spec/features/further_education_payments/student_loan_spec.rb +++ b/spec/features/further_education_payments/student_loan_spec.rb @@ -15,8 +15,7 @@ sign_in_as_service_operator - visit admin_claims_path - find("a[href='#{admin_claim_tasks_path(claim)}']").click + visit admin_claim_tasks_path(claim) within "li.student_loan_plan" do expect(page).to have_content "Incomplete" end @@ -32,8 +31,7 @@ sign_in_as_service_operator - visit admin_claims_path - find("a[href='#{admin_claim_tasks_path(claim)}']").click + visit admin_claim_tasks_path(claim) expect(page).not_to have_content "Student loan plan" end end diff --git a/spec/models/automated_checks/claim_verifiers/student_loan_plan_spec.rb b/spec/models/automated_checks/claim_verifiers/student_loan_plan_spec.rb index d9063b418d..c404f28c4e 100644 --- a/spec/models/automated_checks/claim_verifiers/student_loan_plan_spec.rb +++ b/spec/models/automated_checks/claim_verifiers/student_loan_plan_spec.rb @@ -114,7 +114,7 @@ module ClaimVerifiers let(:submitted_using_slc_data) { false } context "when there is no student loan data for the claim" do - let(:expected_note) { "[SLC Student loan plan] - No data" } + let(:expected_note) { "[SLC Student loan plan] - No matching entry found in the SLC data" } it_behaves_like :creating_a_note_but_no_task end @@ -149,7 +149,7 @@ module ClaimVerifiers let(:submitted_using_slc_data) { nil } context "when there is no student loan data for the claim" do - let(:expected_note) { "[SLC Student loan plan] - No data" } + let(:expected_note) { "[SLC Student loan plan] - No matching entry found in the SLC data" } it_behaves_like :creating_a_note_but_no_task end diff --git a/spec/support/steps/further_education_journey.rb b/spec/support/steps/further_education_journey.rb index 08b9dfa02f..ff6ccc58e4 100644 --- a/spec/support/steps/further_education_journey.rb +++ b/spec/support/steps/further_education_journey.rb @@ -67,8 +67,6 @@ def when_further_education_journey_ready_to_submit choose "No" click_on "Continue" - choose "Personal bank account" - click_on "Continue" fill_in "Name on your account", with: "Jo Bloggs" fill_in "Sort code", with: "123456" fill_in "Account number", with: "87654321"