From dd2a37e990d90a9479cb054ddd87bdedaaf6d581 Mon Sep 17 00:00:00 2001 From: Thomas Leese Date: Fri, 22 Dec 2023 10:49:24 +0000 Subject: [PATCH] Remove email consent letters page We don't need this page anymore as the consent letters are going to be part of the admin journey. --- ...ssment_recommendation_verify_controller.rb | 9 +----- .../email_consent_letters.html.erb | 31 ------------------- config/locales/assessor_interface.en.yml | 2 -- config/routes.rb | 2 -- ...etters_assessment_recommendation_verify.rb | 13 -------- spec/support/page_helpers.rb | 5 --- .../completing_assessment_spec.rb | 11 ------- 7 files changed, 1 insertion(+), 72 deletions(-) delete mode 100644 app/views/assessor_interface/assessment_recommendation_verify/email_consent_letters.html.erb delete mode 100644 spec/support/autoload/page_objects/assessor_interface/email_consent_letters_assessment_recommendation_verify.rb diff --git a/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb b/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb index 6cf6a67500..894b570cdd 100644 --- a/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb +++ b/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb @@ -106,7 +106,7 @@ def update_qualification_requests if @form.save redirect_to [ - :email_consent_letters, + :professional_standing, :assessor_interface, application_form, assessment, @@ -117,13 +117,6 @@ def update_qualification_requests end end - def email_consent_letters - authorize %i[assessor_interface assessment_recommendation], :edit? - - @qualifications = - application_form.qualifications.where(id: session[:qualification_ids]) - end - def edit_professional_standing authorize %i[assessor_interface assessment_recommendation], :edit? diff --git a/app/views/assessor_interface/assessment_recommendation_verify/email_consent_letters.html.erb b/app/views/assessor_interface/assessment_recommendation_verify/email_consent_letters.html.erb deleted file mode 100644 index 3324ed239c..0000000000 --- a/app/views/assessor_interface/assessment_recommendation_verify/email_consent_letters.html.erb +++ /dev/null @@ -1,31 +0,0 @@ -<% content_for :page_title, t(".heading") %> -<% content_for :back_link_url, verify_qualifications_assessor_interface_application_form_assessment_assessment_recommendation_verify_path(@application_form) %> - -

<%= t(".heading") %>

- -

- Step 1 – log in to the Ecctis portal and check the consent letter requirements for: -

- - - -

- Step 2 – arrange for the applicant to receive (and return) the consent letters by email. -

- -

- Step 3 – submit verification requests to Ecctis (attaching the qualification documents and proof of consent). -

- -

- The task list will show a ‘Verify qualifications’ task. The status will remain ‘Waiting on’ until you receive responses from Ecctis. -

- -
- <%= govuk_button_link_to "Continue", [:professional_standing, :assessor_interface, @application_form, @assessment, :assessment_recommendation_verify] %> - <%= govuk_link_to "Cancel", [:assessor_interface, @application_form] %> -
diff --git a/config/locales/assessor_interface.en.yml b/config/locales/assessor_interface.en.yml index 3a0c4df5c4..f0df3250e0 100644 --- a/config/locales/assessor_interface.en.yml +++ b/config/locales/assessor_interface.en.yml @@ -93,8 +93,6 @@ en: heading: Request work history references edit_professional_standing: heading: Do you want to verify LoPS? - email_consent_letters: - heading: Email consent letters preview_referee: heading: Check and send the reference request email preview_teacher: diff --git a/config/routes.rb b/config/routes.rb index da62354924..3714f4b875 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -89,8 +89,6 @@ post "qualification-requests", to: "assessment_recommendation_verify#update_qualification_requests" - get "email-consent-letters", - to: "assessment_recommendation_verify#email_consent_letters" get "reference-requests", to: "assessment_recommendation_verify#edit_reference_requests" post "reference-requests", diff --git a/spec/support/autoload/page_objects/assessor_interface/email_consent_letters_assessment_recommendation_verify.rb b/spec/support/autoload/page_objects/assessor_interface/email_consent_letters_assessment_recommendation_verify.rb deleted file mode 100644 index 99c03bb9c9..0000000000 --- a/spec/support/autoload/page_objects/assessor_interface/email_consent_letters_assessment_recommendation_verify.rb +++ /dev/null @@ -1,13 +0,0 @@ -# frozen_string_literal: true - -module PageObjects - module AssessorInterface - class EmailConsentLettersAssessmentRecommendationVerify < SitePrism::Page - set_url "/assessor/applications/{reference}/assessments/{assessment_id}" \ - "/recommendation/verify/email-consent-letters" - - element :heading, "h1" - element :continue_button, ".govuk-button" - end - end -end diff --git a/spec/support/page_helpers.rb b/spec/support/page_helpers.rb index 47ffa3ee66..bd90952b09 100644 --- a/spec/support/page_helpers.rb +++ b/spec/support/page_helpers.rb @@ -117,11 +117,6 @@ def assessor_edit_work_history_page PageObjects::AssessorInterface::EditWorkHistory.new end - def assessor_email_consent_letters_requests_assessment_recommendation_verify_page - @assessor_email_consent_letters_requests_assessment_recommendation_verify_page ||= - PageObjects::AssessorInterface::EmailConsentLettersAssessmentRecommendationVerify.new - end - def assessor_further_information_request_page @assessor_further_information_request_page ||= PageObjects::AssessorInterface::FurtherInformationRequest.new diff --git a/spec/system/assessor_interface/completing_assessment_spec.rb b/spec/system/assessor_interface/completing_assessment_spec.rb index 303b1d45bf..2f5a65aab6 100644 --- a/spec/system/assessor_interface/completing_assessment_spec.rb +++ b/spec/system/assessor_interface/completing_assessment_spec.rb @@ -108,13 +108,6 @@ ) when_i_select_the_qualifications - then_i_see_the( - :assessor_email_consent_letters_requests_assessment_recommendation_verify_page, - reference:, - assessment_id:, - ) - - when_i_click_continue_from_email_consent_letters then_i_see_the( :assessor_professional_standing_assessment_recommendation_verify_page, reference:, @@ -345,10 +338,6 @@ def when_i_select_the_qualifications .click end - def when_i_click_continue_from_email_consent_letters - assessor_email_consent_letters_requests_assessment_recommendation_verify_page.continue_button.click - end - def when_i_select_yes_verify_professional_standing assessor_professional_standing_assessment_recommendation_verify_page .form