From d24c89802aa810764f989e0647853f45792f98c9 Mon Sep 17 00:00:00 2001
From: Thomas Leese <thomas@leese.io>
Date: Wed, 27 Sep 2023 10:05:24 +0100
Subject: [PATCH] Remove "Contact teaching authority" page

This page is going to be shown on a different page now, so we need to
remove it from the verification flow.
---
 ...ssment_recommendation_verify_controller.rb | 12 +--------
 .../contact_professional_standing.html.erb    | 26 -------------------
 config/routes.rb                              |  3 ---
 spec/support/page_helpers.rb                  |  5 ----
 .../completing_assessment_spec.rb             | 11 --------
 5 files changed, 1 insertion(+), 56 deletions(-)
 delete mode 100644 app/views/assessor_interface/assessment_recommendation_verify/contact_professional_standing.html.erb

diff --git a/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb b/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb
index b33633abf0..74b9e70e3c 100644
--- a/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb
+++ b/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb
@@ -150,13 +150,7 @@ def update_verify_professional_standing
         session[:professional_standing] = @form.verify_professional_standing
 
         redirect_to [
-                      (
-                        if @form.verify_professional_standing
-                          :contact_professional_standing
-                        else
-                          :reference_requests
-                        end
-                      ),
+                      :reference_requests,
                       :assessor_interface,
                       application_form,
                       assessment,
@@ -167,10 +161,6 @@ def update_verify_professional_standing
       end
     end
 
-    def contact_professional_standing
-      authorize :assessor, :edit?
-    end
-
     def edit_reference_requests
       authorize :assessor, :edit?
 
diff --git a/app/views/assessor_interface/assessment_recommendation_verify/contact_professional_standing.html.erb b/app/views/assessor_interface/assessment_recommendation_verify/contact_professional_standing.html.erb
deleted file mode 100644
index 2c1fc7e3c8..0000000000
--- a/app/views/assessor_interface/assessment_recommendation_verify/contact_professional_standing.html.erb
+++ /dev/null
@@ -1,26 +0,0 @@
-<% title = "Contact #{region_teaching_authority_name(@application_form.region)}" %>
-
-<% content_for :page_title, title %>
-<% content_for :back_link_url, verify_professional_standing_assessor_interface_application_form_assessment_assessment_recommendation_verify_path(@application_form) %>
-
-<h1 class="govuk-heading-xl"><%= title %></h1>
-
-<p class="govuk-body">
-  <strong class="govuk-!-font-weight-bold">Step 1</strong> – contact <%= region_teaching_authority_name(@application_form.region) %> to verify that they issued the <%= region_certificate_name(@application_form.region) %> provided by the applicant.
-</p>
-
-<p class="govuk-body">Remember to include the applicant’s:</p>
-
-<ul class="govuk-list govuk-list--bullet">
-  <li>full name</li>
-  <li>date of birth</li>
-</ul>
-
-<p class="govuk-body"><strong class="govuk-!-font-weight-bold">Step 2</strong> – once they respond, use the ‘Record LOPS response’ link on the task list to confirm that a reply has been received.</p>
-
-<p class="govuk-body"><strong class="govuk-!-font-weight-bold">Step 3</strong> – use the ‘Review LOPS response’ to confirm whether or not the response shows that the letter of professional standing is legitimate.</p>
-
-<div class="govuk-button-group">
-  <%= govuk_button_link_to "Continue", [:reference_requests, :assessor_interface, @application_form, @assessment, :assessment_recommendation_verify] %>
-  <%= govuk_link_to "Cancel", assessor_interface_application_form_path(@application_form) %>
-</div>
diff --git a/config/routes.rb b/config/routes.rb
index 3e106f6e04..0f4f3cd8d4 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -94,9 +94,6 @@
           post "verify-professional-standing",
                to:
                  "assessment_recommendation_verify#update_verify_professional_standing"
-          get "contact-professional-standing",
-              to:
-                "assessment_recommendation_verify#contact_professional_standing"
         end
 
         resources :further_information_requests,
diff --git a/spec/support/page_helpers.rb b/spec/support/page_helpers.rb
index f67c1e11ab..8760477ab4 100644
--- a/spec/support/page_helpers.rb
+++ b/spec/support/page_helpers.rb
@@ -129,11 +129,6 @@ def confirm_assessment_recommendation_page
       PageObjects::AssessorInterface::ConfirmAssessmentRecommendation.new
   end
 
-  def contact_professional_standing_assessment_recommendation_verify_page
-    @contact_professional_standing_assessment_recommendation_verify_page ||=
-      PageObjects::AssessorInterface::ContactProfessionalStandingAssessmentRecommendationVerify.new
-  end
-
   def declare_assessment_recommendation_page
     @declare_assessment_recommendation_page ||=
       PageObjects::AssessorInterface::DeclareAssessmentRecommendation.new
diff --git a/spec/system/assessor_interface/completing_assessment_spec.rb b/spec/system/assessor_interface/completing_assessment_spec.rb
index e3ce1e0236..5d76d89200 100644
--- a/spec/system/assessor_interface/completing_assessment_spec.rb
+++ b/spec/system/assessor_interface/completing_assessment_spec.rb
@@ -110,13 +110,6 @@
     )
 
     when_i_select_yes_verify_professional_standing
-    then_i_see_the(
-      :contact_professional_standing_assessment_recommendation_verify_page,
-      application_id:,
-      assessment_id:,
-    )
-
-    when_i_click_continue_from_contact_professional_standing
     then_i_see_the(
       :reference_requests_assessment_recommendation_verify_page,
       application_id:,
@@ -341,10 +334,6 @@ def when_i_select_yes_verify_professional_standing
       .click
   end
 
-  def when_i_click_continue_from_contact_professional_standing
-    contact_professional_standing_assessment_recommendation_verify_page.continue_button.click
-  end
-
   def when_i_select_the_work_histories
     reference_requests_assessment_recommendation_verify_page
       .form