From 88719abee62ea20bc1ea536a7177f3952cb175da Mon Sep 17 00:00:00 2001
From: Shujat Khalid <khalidshujat@gmail.com>
Date: Fri, 31 May 2024 10:04:01 +0100
Subject: [PATCH] suggested changes made

---
 app/mailers/teacher_mailer.rb                 | 4 ++--
 app/views/teachers/mailer/magic_link.text.erb | 4 +---
 config/locales/mailer.en.yml                  | 4 ++--
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/app/mailers/teacher_mailer.rb b/app/mailers/teacher_mailer.rb
index 92390e0506..83e1c3a1eb 100644
--- a/app/mailers/teacher_mailer.rb
+++ b/app/mailers/teacher_mailer.rb
@@ -51,10 +51,10 @@ def application_not_submitted
   def application_received
     subject =
       if @application_form.teaching_authority_provides_written_statement
-        I18n.t("mailer.teacher.application_received.subject.true")
+        I18n.t("mailer.teacher.application_received.subject.without_document")
       else
         I18n.t(
-          "mailer.teacher.application_received.subject.false",
+          "mailer.teacher.application_received.subject.awaiting_document",
           certificate: region_certificate_name(region),
         )
       end
diff --git a/app/views/teachers/mailer/magic_link.text.erb b/app/views/teachers/mailer/magic_link.text.erb
index d16f433682..60cf8465f2 100644
--- a/app/views/teachers/mailer/magic_link.text.erb
+++ b/app/views/teachers/mailer/magic_link.text.erb
@@ -11,6 +11,4 @@ Welcome back to apply for qualified teacher status (QTS) in England. Use the lin
 
 Please note, this link will expire in <%= Devise.passwordless_login_within.inspect %>. After that time, you will need to [return to the service](<%= create_or_new_teacher_session_url %>) and request another confirmation link.
 
-Kind regards,
-
-The Teacher Qualifications Team
+<%= render "shared/teacher_mailer/footer" %>
diff --git a/config/locales/mailer.en.yml b/config/locales/mailer.en.yml
index 6326043eb6..b45872dfaf 100644
--- a/config/locales/mailer.en.yml
+++ b/config/locales/mailer.en.yml
@@ -20,8 +20,8 @@ en:
           1: Your draft QTS application is about to be deleted
       application_received:
         subject:
-          true: Your QTS application has been received
-          false: "Your QTS application: Awaiting %{certificate}"
+          without_document: Your QTS application has been received
+          awaiting_document: "Your QTS application: Awaiting %{certificate}"
       consent_reminder:
         subject: "Reminder: we need your written consent to progress your QTS application"
       consent_requested: