diff --git a/Gemfile.lock b/Gemfile.lock index 4be30666c5..c74cf20ead 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -183,9 +183,9 @@ GEM email_address (0.2.4) simpleidn erubi (1.12.0) - et-orbi (1.2.7) + et-orbi (1.2.11) tzinfo - factory_bot (6.4.5) + factory_bot (6.4.6) activesupport (>= 5.0.0) factory_bot_rails (6.4.3) factory_bot (~> 6.4) @@ -223,8 +223,8 @@ GEM webrick (~> 1.7) websocket-driver (>= 0.6, < 0.8) ffi (1.16.3) - fugit (1.9.0) - et-orbi (~> 1, >= 1.2.7) + fugit (1.11.0) + et-orbi (~> 1, >= 1.2.11) raabro (~> 1.4) globalid (1.2.1) activesupport (>= 6.1) @@ -258,11 +258,11 @@ GEM multi_json (~> 1.11) os (>= 0.9, < 2.0) signet (>= 0.16, < 2.a) - govuk-components (4.1.2) + govuk-components (5.3.2) html-attributes-utils (~> 1.0.0, >= 1.0.0) - pagy (~> 6.0) - view_component (>= 3.3, < 3.7) - govuk_design_system_formbuilder (4.1.1) + pagy (>= 6, < 8) + view_component (>= 3.9, < 3.12) + govuk_design_system_formbuilder (5.3.3) actionview (>= 6.1) activemodel (>= 6.1) activesupport (>= 6.1) @@ -289,7 +289,7 @@ GEM reline (>= 0.4.2) jsbundling-rails (1.3.0) railties (>= 6.0.0) - json (2.7.1) + json (2.7.2) jwt (2.8.1) base64 language_server-protocol (3.17.0.3) @@ -309,9 +309,9 @@ GEM activesupport (>= 5.2.8.1) notifications-ruby-client (~> 6.0) rack (>= 2.1.4.1) - marcel (1.0.2) + marcel (1.0.4) matrix (0.4.2) - method_source (1.0.0) + method_source (1.1.0) mini_mime (1.1.5) minitest (5.22.3) msgpack (1.7.2) @@ -330,7 +330,7 @@ GEM timeout net-smtp (0.5.0) net-protocol - nio4r (2.7.0) + nio4r (2.7.1) nokogiri (1.16.4-arm64-darwin) racc (~> 1.4) nokogiri (1.16.4-x86_64-darwin) @@ -362,7 +362,7 @@ GEM omniauth (~> 2.0) orm_adapter (0.5.0) os (1.1.4) - pagy (6.5.0) + pagy (7.0.11) parallel (1.24.0) parser (3.3.0.5) ast (~> 2.4.1) @@ -392,7 +392,8 @@ GEM rack (2.2.9) rack-attack (6.7.0) rack (>= 1.0, < 4) - rack-protection (3.1.0) + rack-protection (3.2.0) + base64 (>= 0.1.0) rack (~> 2.2, >= 2.2.4) rack-session (1.0.2) rack (< 3) @@ -436,14 +437,14 @@ GEM zeitwerk (~> 2.6) rainbow (3.1.1) rake (13.2.1) - rbs (3.4.1) + rbs (3.4.4) abbrev rdoc (6.6.3.1) psych (>= 4.0.0) redcarpet (3.6.0) redis (4.8.1) regexp_parser (2.9.0) - reline (0.5.1) + reline (0.5.3) io-console (~> 0.5) representable (3.2.0) declarative (< 0.1.0) @@ -516,7 +517,7 @@ GEM rubocop-capybara (~> 2.17) rubocop-factory_bot (~> 2.22) rubocop-rspec_rails (~> 2.28) - rubocop-rspec_rails (2.28.2) + rubocop-rspec_rails (2.28.3) rubocop (~> 1.40) ruby-progressbar (1.13.0) ruby-rc4 (0.1.5) @@ -525,7 +526,6 @@ GEM ruby2_keywords (0.0.5) semantic_logger (4.15.0) concurrent-ruby (~> 1.0) - railties (>= 5.0) sentry-rails (5.17.3) railties (>= 5.0) sentry-ruby (~> 5.17.3) @@ -553,7 +553,7 @@ GEM addressable (~> 2.8, >= 2.8.1) capybara (~> 3.31) site_prism-all_there (> 2, < 5) - site_prism-all_there (3.0.3) + site_prism-all_there (3.0.4) sitemap_generator (6.3.0) builder (~> 3.0) snaky_hash (2.0.1) @@ -587,8 +587,8 @@ GEM validate_url (1.0.15) activemodel (>= 3.0.0) public_suffix - version_gem (1.1.3) - view_component (3.6.0) + version_gem (1.1.4) + view_component (3.11.0) activesupport (>= 5.2.0, < 8.0) concurrent-ruby (~> 1.0) method_source (~> 1.0) diff --git a/app/assets/stylesheets/_task_list.scss b/app/assets/stylesheets/_task_list.scss deleted file mode 100644 index dca012f558..0000000000 --- a/app/assets/stylesheets/_task_list.scss +++ /dev/null @@ -1,70 +0,0 @@ -.app-task-list { - list-style-type: none; - padding-left: 0; - margin-top: 0; - margin-bottom: 0; - @include govuk-media-query($from: tablet) { - min-width: 550px; - } -} - -.app-task-list__section { - display: table; - @include govuk-font($size: 24, $weight: bold); -} - -.app-task-list__section-number { - display: table-cell; - - @include govuk-media-query($from: tablet) { - min-width: govuk-spacing(6); - padding-right: 0; - } -} - -.app-task-list__items-no-indentation { - @include govuk-font($size: 19); - @include govuk-responsive-margin(9, "bottom"); - list-style: none; - padding-left: 0; -} - -.app-task-list__items { - @include govuk-font($size: 19); - @include govuk-responsive-margin(9, "bottom"); - list-style: none; - padding-left: 0; - @include govuk-media-query($from: tablet) { - padding-left: govuk-spacing(6); - } -} - -.app-task-list__item { - border-bottom: 1px solid $govuk-border-colour; - margin-bottom: 0 !important; - padding-top: govuk-spacing(2); - padding-bottom: govuk-spacing(2); - @include govuk-clearfix; -} - -.app-task-list__item:first-child { - border-top: 1px solid $govuk-border-colour; -} - -.app-task-list__task-name { - display: block; - @include govuk-media-query($from: 450px) { - float: left; - } -} - -.app-task-list__tag { - margin-top: govuk-spacing(2); - margin-bottom: govuk-spacing(1); - - @include govuk-media-query($from: 450px) { - float: right; - margin-top: 0; - margin-bottom: 0; - } -} diff --git a/app/assets/stylesheets/application.sass.scss b/app/assets/stylesheets/application.sass.scss index 36c4594cf1..d642ae0961 100644 --- a/app/assets/stylesheets/application.sass.scss +++ b/app/assets/stylesheets/application.sass.scss @@ -3,7 +3,7 @@ $govuk-new-link-styles: true; $govuk-assets-path: "/"; $moj-images-path: "/"; -@import "govuk-frontend/govuk/all"; +@import "govuk-frontend/dist/govuk/all"; @import "@ministryofjustice/frontend/moj/components/ticket-panel/ticket-panel"; @import "@ministryofjustice/frontend/moj/components/timeline/timeline"; @import "dfe-autocomplete/src/dfe-autocomplete"; @@ -15,7 +15,6 @@ $moj-images-path: "/"; @import "_environments"; @import "_search_results"; @import "_support"; -@import "_task_list"; ul.autocomplete__menu { li { diff --git a/app/components/task_list/component.html.erb b/app/components/task_list/component.html.erb deleted file mode 100644 index 6820a071ec..0000000000 --- a/app/components/task_list/component.html.erb +++ /dev/null @@ -1,33 +0,0 @@ -
    - <% sections.each do |section| %> -
  1. - <% if (title = section[:title]).present? %> -

    - <% if sections.count > 1 %> - <%= section[:number] %>. - <% end %> - - <%= title %> -

    - <% end %> - - -
  2. - <% end %> -
diff --git a/app/components/task_list/component.rb b/app/components/task_list/component.rb deleted file mode 100644 index ac12461ce6..0000000000 --- a/app/components/task_list/component.rb +++ /dev/null @@ -1,42 +0,0 @@ -# frozen_string_literal: true - -module TaskList - class Component < ViewComponent::Base - ## - # Renders a task list from the following data structure: - # - # sections: [ - # { - # title: "Title", - # items: [ - # { - # name: "Do this thing", - # link: "/do-this-thing", - # status: "not_started" - # } - # ] - # } - # ] - - def initialize(sections) - super - @sections = sections - end - - def sections - @sections - .filter { |section| section[:items].present? } - .each_with_index - .map do |section, index| - section.merge( - number: index + 1, - key: section[:title]&.parameterize, - items: - section[:items].map do |item| - item.merge(key: item[:name].parameterize) - end, - ) - end - end - end -end diff --git a/app/forms/teacher_interface/english_language_provider_form.rb b/app/forms/teacher_interface/english_language_provider_form.rb index a5ca9dfa6f..47c01ec122 100644 --- a/app/forms/teacher_interface/english_language_provider_form.rb +++ b/app/forms/teacher_interface/english_language_provider_form.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require "ostruct" + module TeacherInterface class EnglishLanguageProviderForm < BaseForm attr_accessor :application_form diff --git a/app/helpers/upload_helper.rb b/app/helpers/upload_helper.rb index 73f8988c76..d42dd11860 100644 --- a/app/helpers/upload_helper.rb +++ b/app/helpers/upload_helper.rb @@ -11,12 +11,7 @@ def upload_link_to(upload) ) end elsif upload.safe_to_link? - govuk_link_to( - "#{upload.filename} (opens in a new tab)", - upload_path(upload), - target: :_blank, - rel: :noopener, - ) + govuk_link_to(upload.filename, upload_path(upload), new_tab: true) else upload.filename end diff --git a/app/view_objects/assessor_interface/qualification_requests_view_object.rb b/app/view_objects/assessor_interface/qualification_requests_view_object.rb index 918632c5d7..34a5a8e335 100644 --- a/app/view_objects/assessor_interface/qualification_requests_view_object.rb +++ b/app/view_objects/assessor_interface/qualification_requests_view_object.rb @@ -65,8 +65,8 @@ def check_consent_method_task_item consent_requests.exists? || qualification_requests.requested.exists? { - name: "Check and select consent method", - link: + title: "Check and select consent method", + href: unless cannot_change [ ( @@ -100,8 +100,8 @@ def generate_consent_document_in_all_qualifications? def generate_consent_document_task_item { - name: "Generate consent document", - link: [ + title: "Generate consent document", + href: [ :unsigned_consent_document, :assessor_interface, application_form, @@ -133,9 +133,9 @@ def send_consent_document_task_item all_consents_requested = consent_requests.all?(&:requested?) { - name: + title: "Send consent #{"document".pluralize(consent_requests.count)} to applicant", - link: + href: if all_documents_completed && !all_consents_requested [ :request, @@ -162,8 +162,8 @@ def signed_consent_method_task_items(qualification_request) [ { - name: "Upload consent document", - link: + title: "Upload consent document", + href: if consent_request.nil? Rails .application @@ -190,8 +190,8 @@ def signed_consent_method_task_items(qualification_request) send_consent_document_task_item end, { - name: "Record applicant response", - link: + title: "Record applicant response", + href: if consent_request&.requested? [ :verify, @@ -239,8 +239,8 @@ def ecctis_task_items(qualification_request) [ { - name: "Request Ecctis verification", - link: + title: "Request Ecctis verification", + href: if can_start && !qualification_request.requested? [ :request, @@ -260,8 +260,8 @@ def ecctis_task_items(qualification_request) end, }, { - name: "Record Ecctis response", - link: + title: "Record Ecctis response", + href: if qualification_request.requested? [ :verify, diff --git a/app/view_objects/teacher_interface/further_information_request_view_object.rb b/app/view_objects/teacher_interface/further_information_request_view_object.rb index f80d4655a5..d4e01d314f 100644 --- a/app/view_objects/teacher_interface/further_information_request_view_object.rb +++ b/app/view_objects/teacher_interface/further_information_request_view_object.rb @@ -15,26 +15,23 @@ def further_information_request .find(params[:id]) end - def task_list_sections - items = - further_information_request - .items - .order(:created_at) - .map do |item| - { - name: item_name(item), - link: [ - :edit, - :teacher_interface, - :application_form, - further_information_request, - item, - ], - status: item.status, - } - end - - [{ title: "Further information requested", items: }] + def task_list_items + further_information_request + .items + .order(:created_at) + .map do |item| + { + title: item_name(item), + href: [ + :edit, + :teacher_interface, + :application_form, + further_information_request, + item, + ], + status: item.status, + } + end end def can_check_answers? diff --git a/app/views/assessor_interface/application_forms/index.html.erb b/app/views/assessor_interface/application_forms/index.html.erb index b086564f74..de26e255e4 100644 --- a/app/views/assessor_interface/application_forms/index.html.erb +++ b/app/views/assessor_interface/application_forms/index.html.erb @@ -9,7 +9,7 @@ <%= f.govuk_submit t(".filters.apply") do %> <%= t(".filters.clear") %> - <%= t(".filters.of_filter") %> + <%= govuk_visually_hidden(t(".filters.of_filter")) %> <% end %> diff --git a/app/views/assessor_interface/application_forms/show.html.erb b/app/views/assessor_interface/application_forms/show.html.erb index e9b268d84f..8dd236bd2e 100644 --- a/app/views/assessor_interface/application_forms/show.html.erb +++ b/app/views/assessor_interface/application_forms/show.html.erb @@ -30,4 +30,14 @@

Task list

-<%= render(TaskList::Component.new(@view_object.task_list_sections)) %> +<% @view_object.task_list_sections.each do |section| %> + <% if (items = section[:items]).present? %> +

<%= section[:title] %>

+ + <%= govuk_task_list(id_prefix: section[:title].parameterize) do |task_list| + items.each do |item| + task_list.with_item(title: item[:name], href: item[:link], status: render(StatusTag::Component.new(item[:status]))) + end + end %> + <% end %> +<% end %> diff --git a/app/views/assessor_interface/assessment_sections/_english_language_provider_details.html.erb b/app/views/assessor_interface/assessment_sections/_english_language_provider_details.html.erb index de551121d0..5279a5e6c4 100644 --- a/app/views/assessor_interface/assessment_sections/_english_language_provider_details.html.erb +++ b/app/views/assessor_interface/assessment_sections/_english_language_provider_details.html.erb @@ -6,7 +6,7 @@ <% if provider.check_url.present? %>

Check the applicant’s <%= provider.reference_name %> at:

-

<%= govuk_link_to provider.check_url, provider.check_url, target: "_blank", rel: "noreferrer noopener" %>

+

<%= govuk_link_to provider.check_url, provider.check_url, new_tab: true %>

<% end %> <% else %>

@@ -14,7 +14,7 @@

- <%= govuk_link_to "Approved providers", "https://register.ofqual.gov.uk/Search?category=Qualifications&query=ESOl", target: "_blank", rel: "noreferrer noopener" %> + <%= govuk_link_to "Approved providers", "https://register.ofqual.gov.uk/Search?category=Qualifications&query=ESOl", new_tab: true %>

<% end %> <% end %> diff --git a/app/views/assessor_interface/assessment_sections/_professional_standing_summary.html.erb b/app/views/assessor_interface/assessment_sections/_professional_standing_summary.html.erb index 679a3bc2db..5725bb899d 100644 --- a/app/views/assessor_interface/assessment_sections/_professional_standing_summary.html.erb +++ b/app/views/assessor_interface/assessment_sections/_professional_standing_summary.html.erb @@ -24,7 +24,7 @@ <% if (online_checker_url = region.teaching_authority_online_checker_url).present? %> <% accordion.with_section(heading_text: "Online checker") do %>

This authority has an online checker for validating the supplied registration number:

-

<%= govuk_link_to online_checker_url, online_checker_url, target: "_blank", rel: "noreferrer noopener" %>

+

<%= govuk_link_to online_checker_url, online_checker_url, new_tab: true %>

<% end %> <% end %> diff --git a/app/views/assessor_interface/assessments/review.html.erb b/app/views/assessor_interface/assessments/review.html.erb index 16925e2414..482c1482d0 100644 --- a/app/views/assessor_interface/assessments/review.html.erb +++ b/app/views/assessor_interface/assessments/review.html.erb @@ -12,55 +12,49 @@ <% if @professional_standing_request.present? %>

LoPS

- <%= render(TaskList::Component.new([{ - indentation: false, - items: [ - { - name: region_teaching_authority_name(@application_form.region, context: :assessor).upcase_first, - link: [:review, :assessor_interface, @application_form, @assessment, :professional_standing_request], - status: @professional_standing_request.review_status, - } - ], - }])) %> + <%= govuk_task_list(id_prefix: "lops") do |task_list| + task_list.with_item( + title: region_teaching_authority_name(@application_form.region, context: :assessor).upcase_first, + href: [:review, :assessor_interface, @application_form, @assessment, :professional_standing_request], + status: render(StatusTag::Component.new(@professional_standing_request.review_status)), + ) + end %> <% end %> - <% if @consent_requests.present? || @qualification_requests.present? %>

Qualifications

- <%= render(TaskList::Component.new([{ - indentation: false, - items: @consent_requests.map do |consent_request| - { - name: qualification_title(consent_request.qualification), - link: [:review, :assessor_interface, @application_form, @assessment, consent_request], - status: consent_request.review_status, - } - end + @qualification_requests.map do |qualification_request| - { - name: qualification_title(qualification_request.qualification), - link: [:review, :assessor_interface, @application_form, @assessment, qualification_request], - status: qualification_request.review_status, - } - end - }])) %> + <%= govuk_task_list(id_prefix: "qualifications") do |task_list| + @consent_requests.each do |consent_request| + task_list.with_item( + title: qualification_title(consent_request.qualification), + href: [:review, :assessor_interface, @application_form, @assessment, consent_request], + status: render(StatusTag::Component.new(consent_request.review_status)), + ) + end + + @qualification_requests.each do |qualification_request| + task_list.with_item( + title: qualification_title(qualification_request.qualification), + href: [:review, :assessor_interface, @application_form, @assessment, qualification_request], + status: render(StatusTag::Component.new(qualification_request.review_status)), + ) + end + end %> <% end %> <% if @reference_requests.present? %>

References

- <%= render(TaskList::Component.new([{ - indentation: false, - items: @reference_requests.map do |reference_request| - { - name: work_history_name(reference_request.work_history), - link: [:review, :assessor_interface, @application_form, @assessment, reference_request], - status: reference_request.review_status, - } - end - }])) %> + <%= govuk_task_list(id_prefix: "references") do |task_list| + @reference_requests.each do |reference_request| + task_list.with_item( + title: work_history_name(reference_request.work_history), + href: [:review, :assessor_interface, @application_form, @assessment, reference_request], + status: render(StatusTag::Component.new(reference_request.review_status)), + ) + end + end %> <% end %> -
- <%= govuk_button_link_to "Back to overview", [:assessor_interface, @application_form] %> -
+<%= govuk_button_link_to "Back to overview", [:assessor_interface, @application_form] %> diff --git a/app/views/assessor_interface/consent_requests/edit_verify.html.erb b/app/views/assessor_interface/consent_requests/edit_verify.html.erb index 17047bb28e..872de8d30a 100644 --- a/app/views/assessor_interface/consent_requests/edit_verify.html.erb +++ b/app/views/assessor_interface/consent_requests/edit_verify.html.erb @@ -22,10 +22,10 @@
<% if upload.is_pdf? %> - <%= govuk_button_link_to "Download", [:assessor_interface, :application_form, upload.document, upload], target: "_blank", rel: "noreferrer noopener" %> + <%= govuk_button_link_to "Download", [:assessor_interface, :application_form, upload.document, upload], new_tab: true %> <% else %> - <%= govuk_button_link_to "Download original", [:assessor_interface, :application_form, upload.document, upload], target: "_blank", rel: "noreferrer noopener" %> - <%= govuk_button_link_to "Download as PDF", assessor_interface_application_form_document_pdf_path(upload.document, "original"), inverse: true, target: "_blank", rel: "noreferrer noopener" %> + <%= govuk_button_link_to "Download original", [:assessor_interface, :application_form, upload.document, upload], new_tab: true %> + <%= govuk_button_link_to "Download as PDF", assessor_interface_application_form_document_pdf_path(upload.document, "original"), inverse: true, new_tab: true %> <% end %>
<% else %> diff --git a/app/views/assessor_interface/professional_standing_requests/show.html.erb b/app/views/assessor_interface/professional_standing_requests/show.html.erb index 77c36b67b8..3dda9ac0d5 100644 --- a/app/views/assessor_interface/professional_standing_requests/show.html.erb +++ b/app/views/assessor_interface/professional_standing_requests/show.html.erb @@ -7,40 +7,34 @@ You need to request verification for this application’s LoPS.

-<%= render(TaskList::Component.new( - [ - { - indentation: false, - items: [ - { - name: "Request LoPS verification", - link: unless @professional_standing_request.requested? - [ - :request, - :assessor_interface, - @application_form, - @assessment, - :professional_standing_request, - ] - end, - status: @professional_standing_request.requested? ? "completed" : "not_started" - }, - { - name: "Record LoPS response", - link: if @professional_standing_request.requested? - [ - :verify, - :assessor_interface, - @application_form, - @assessment, - :professional_standing_request - ] - end, - status: @professional_standing_request.status - } - ], - } - ] -)) %> +<%= govuk_task_list do |task_list| + task_list.with_item( + title: "Request LoPS verification", + href: unless @professional_standing_request.requested? + [ + :request, + :assessor_interface, + @application_form, + @assessment, + :professional_standing_request, + ] + end, + status: render(StatusTag::Component.new(@professional_standing_request.requested? ? "completed" : "not_started")) + ) + + task_list.with_item( + title: "Record LoPS response", + href: if @professional_standing_request.requested? + [ + :verify, + :assessor_interface, + @application_form, + @assessment, + :professional_standing_request + ] + end, + status: render(StatusTag::Component.new(@professional_standing_request.status)) + ) +end %> <%= govuk_button_link_to "Back to overview", [:assessor_interface, @application_form] %> diff --git a/app/views/assessor_interface/qualification_requests/edit_unsigned_consent_document.html.erb b/app/views/assessor_interface/qualification_requests/edit_unsigned_consent_document.html.erb index c093da4e74..c5c769a260 100644 --- a/app/views/assessor_interface/qualification_requests/edit_unsigned_consent_document.html.erb +++ b/app/views/assessor_interface/qualification_requests/edit_unsigned_consent_document.html.erb @@ -22,7 +22,7 @@
- <%= govuk_button_link_to "Generate consent document", [:generate_unsigned_consent_document, :assessor_interface, @application_form, @assessment, :qualification_requests], inverse: true, target: :_blank, rel: :noopener %> + <%= govuk_button_link_to "Generate consent document", [:generate_unsigned_consent_document, :assessor_interface, @application_form, @assessment, :qualification_requests], inverse: true, new_tab: true %>
diff --git a/app/views/assessor_interface/qualification_requests/index.html.erb b/app/views/assessor_interface/qualification_requests/index.html.erb index dabdc17c3d..5c9adc8f40 100644 --- a/app/views/assessor_interface/qualification_requests/index.html.erb +++ b/app/views/assessor_interface/qualification_requests/index.html.erb @@ -11,12 +11,13 @@

Complete the following tasks:

<% end %> -<%= render TaskList::Component.new([ - { - indentation: false, - items: @view_object.all_task_items - } -]) %> +<%= govuk_task_list do |task_list| + @view_object.all_task_items.each do |item| + task_list.with_item( + title: item[:title], href: item[:href], status: render(StatusTag::Component.new(item[:status])) + ) + end +end %> <% if @view_object.show_individual_task_items? %>

Qualification specific

@@ -26,12 +27,13 @@ <% @view_object.qualification_requests.map do |qualification_request| %>

<%= qualification_title(qualification_request.qualification) %>

- <%= render TaskList::Component.new([ - { - indentation: false, - items: @view_object.individual_task_items_for(qualification_request:) - } - ]) %> + <%= govuk_task_list do |task_list| + @view_object.individual_task_items_for(qualification_request:).each do |item| + task_list.with_item( + title: item[:title], href: item[:href], status: render(StatusTag::Component.new(item[:status])) + ) + end + end %> <% end %> <% end %> diff --git a/app/views/assessor_interface/reference_requests/index.html.erb b/app/views/assessor_interface/reference_requests/index.html.erb index ba42090ad2..c6acb62716 100644 --- a/app/views/assessor_interface/reference_requests/index.html.erb +++ b/app/views/assessor_interface/reference_requests/index.html.erb @@ -8,18 +8,16 @@ You can review those that have the status RECEIVED.

-<%= render TaskList::Component.new([ - { - title: "References to verify", - indentation: false, - items: @reference_requests.map do |reference_request| - { - name: work_history_name_and_duration(reference_request.work_history), - link: [:verify, :assessor_interface, @application_form, @assessment, reference_request], - status: reference_request.status - } - end - } -]) %> +

References to verify

+ +<%= govuk_task_list do |task_list| + @reference_requests.each do |reference_request| + task_list.with_item( + title: work_history_name_and_duration(reference_request.work_history), + href: [:verify, :assessor_interface, @application_form, @assessment, reference_request], + status: render(StatusTag::Component.new(reference_request.status)) + ) + end +end %> <%= govuk_button_link_to "Back to overview", [:assessor_interface, @application_form] %> diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 94fb14baac..344b70f3e7 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -10,21 +10,20 @@ <%= tag :meta, name: 'viewport', content: 'width=device-width, initial-scale=1' %> <%= tag :meta, property: 'og:image', content: asset_path('images/govuk-opengraph-image.png') %> <%= tag :meta, name: 'theme-color', content: '#0b0c0c' %> - <%= favicon_link_tag asset_path('images/favicon.ico') %> - <%= favicon_link_tag asset_path('images/govuk-mask-icon.svg'), rel: 'mask-icon', type: 'image/svg', color: "#0b0c0c" %> - <%= favicon_link_tag asset_path('images/govuk-apple-touch-icon.png'), rel: 'apple-touch-icon', type: 'image/png' %> - <%= favicon_link_tag asset_path('images/govuk-apple-touch-icon-152x152.png'), rel: 'apple-touch-icon', type: 'image/png', size: '152x152' %> - <%= favicon_link_tag asset_path('images/govuk-apple-touch-icon-167x167.png'), rel: 'apple-touch-icon', type: 'image/png', size: '167x167' %> - <%= favicon_link_tag asset_path('images/govuk-apple-touch-icon-180x180.png'), rel: 'apple-touch-icon', type: 'image/png', size: '180x180' %> + + <%= favicon_link_tag image_path('images/favicon.ico'), type: nil, sizes: "48x48" %> + <%= favicon_link_tag image_path('images/favicon.svg'), type: 'image/svg+xml', sizes: "any" %> + <%= favicon_link_tag image_path('images/govuk-icon-mask.svg'), rel: 'mask-icon', color: "#0b0c0c", type: nil %> + <%= favicon_link_tag image_path('images/govuk-icon-180.png'), rel: 'apple-touch-icon', type: nil %> <%= stylesheet_link_tag "application" %> <%= javascript_include_tag "application", defer: true %> - <%= javascript_tag nonce: true do -%> - document.body.className = ((document.body.className) ? document.body.className + ' js-enabled' : 'js-enabled'); - <% end -%> + <%= javascript_tag nonce: true do %> + document.body.className += ' js-enabled' + ('noModule' in HTMLScriptElement.prototype ? ' govuk-frontend-supported' : ''); + <% end %> <%= govuk_skip_link %> diff --git a/app/views/shared/_employment_warning.html.erb b/app/views/shared/_employment_warning.html.erb index 4095369300..8995c936df 100644 --- a/app/views/shared/_employment_warning.html.erb +++ b/app/views/shared/_employment_warning.html.erb @@ -1,4 +1,4 @@ <%= govuk_warning_text do %> The Department for Education (DfE) does not employ teachers directly. - To find a teaching job, you must <%= govuk_link_to "apply to individual schools in England", "https://getintoteaching.education.gov.uk/non-uk-teachers/teach-in-england-if-you-trained-overseas/#find-a-teaching-job", target: "_blank", rel: "noreferrer noopener" %>. + To find a teaching job, you must <%= govuk_link_to "apply to individual schools in England", "https://getintoteaching.education.gov.uk/non-uk-teachers/teach-in-england-if-you-trained-overseas/#find-a-teaching-job", new_tab: true %>. <% end %> diff --git a/app/views/shared/_english_language_approved_providers.html.erb b/app/views/shared/_english_language_approved_providers.html.erb index b4fd13ff9e..7c3bab3491 100644 --- a/app/views/shared/_english_language_approved_providers.html.erb +++ b/app/views/shared/_english_language_approved_providers.html.erb @@ -10,7 +10,6 @@

See the list of <%= govuk_link_to "approved providers (opens in new tab)", reduced_evidence_accepted ? "https://register.ofqual.gov.uk/Search?category=Qualifications&query=ESOl" : english_language_guidance_path, - rel: "noreferrer noopener", - target: "_blank" %>. + new_tab: true %>.

<% end %> diff --git a/app/views/shared/_header.html.erb b/app/views/shared/_header.html.erb index 83ca169c80..28c7a32ae8 100644 --- a/app/views/shared/_header.html.erb +++ b/app/views/shared/_header.html.erb @@ -4,22 +4,6 @@ service_url: "/#{current_namespace}", classes: "app-header--#{HostingEnvironment.name}" ) do |header| %> - <% header.with_custom_logo do %> - - GOV.UK - - - <% end %> - <% case current_namespace %> <% when "assessor" %> <% if current_staff %> diff --git a/app/views/shared/eligible_region_content_components/_certified_translation.html.erb b/app/views/shared/eligible_region_content_components/_certified_translation.html.erb index 88cd58020a..d0c99e910f 100644 --- a/app/views/shared/eligible_region_content_components/_certified_translation.html.erb +++ b/app/views/shared/eligible_region_content_components/_certified_translation.html.erb @@ -26,7 +26,7 @@

Finding a certified translator

- We cannot recommend translation providers. You can find a professional translator through the <%= govuk_link_to "Institute of Translating and Interpreting (ITI) (opens in new tab)", "https://www.iti.org.uk/component/itisearch/?view=translators", target: :_blank, rel: :noopener %>. All listed translators have been certified by the ITI and are qualified to complete translations. + We cannot recommend translation providers. You can find a professional translator through the <%= govuk_link_to "Institute of Translating and Interpreting (ITI) (opens in new tab)", "https://www.iti.org.uk/component/itisearch/?view=translators", new_tab: true %>. All listed translators have been certified by the ITI and are qualified to complete translations.

diff --git a/app/views/shared/eligible_region_content_components/_english_language.html.erb b/app/views/shared/eligible_region_content_components/_english_language.html.erb index 0e03e4f1a7..ad5448d0c4 100644 --- a/app/views/shared/eligible_region_content_components/_english_language.html.erb +++ b/app/views/shared/eligible_region_content_components/_english_language.html.erb @@ -30,7 +30,7 @@

You’ll need a Secure English Language Test (SELT) at level B2 from an approved provider.

<% else %>

- If you cannot provide one of the documents described in 1,2 or 3, you'll need a B2 level Secure English Language Test (SELT) from on approved provider. We accept the following approved providers and tests: + If you cannot provide one of the documents described in 1,2 or 3, you'll need a <%= govuk_link_to "B2 level", "https://www.coe.int/en/web/common-european-framework-reference-languages/table-1-cefr-3.3-common-reference-levels-global-scale", new_tab: true %> Secure English Language Test (SELT) from on approved provider. We accept the following approved providers and tests: