From 5d8368d630358fc2217d36da287bba1174aea7a2 Mon Sep 17 00:00:00 2001 From: Thomas Leese Date: Fri, 13 Oct 2023 14:31:33 +0100 Subject: [PATCH] Order page helpers alphabetically This should make them easier to find in the future. --- .../work_experience/new.html.erb | 1 - spec/support/page_helpers.rb | 92 +++++++++---------- 2 files changed, 46 insertions(+), 47 deletions(-) diff --git a/app/views/eligibility_interface/work_experience/new.html.erb b/app/views/eligibility_interface/work_experience/new.html.erb index a9d4076062..0882962d14 100644 --- a/app/views/eligibility_interface/work_experience/new.html.erb +++ b/app/views/eligibility_interface/work_experience/new.html.erb @@ -1,4 +1,3 @@ - <% content_for :page_title, "#{'Error: ' if @work_experience_form.errors.any?}#{t("helpers.legend.eligibility_interface_work_experience_form.work_experience")}" %> <% content_for :back_link_url, back_link_url(@eligibility_check.qualified_for_subject_required? ? eligibility_interface_qualified_for_subject_path : eligibility_interface_teach_children_path) %> diff --git a/spec/support/page_helpers.rb b/spec/support/page_helpers.rb index 7816aba7c1..f579c954d1 100644 --- a/spec/support/page_helpers.rb +++ b/spec/support/page_helpers.rb @@ -17,21 +17,26 @@ def assessor_application_page PageObjects::AssessorInterface::Application.new end - def assessor_applications_page - @assessor_applications_page ||= - PageObjects::AssessorInterface::Applications.new - end - def assessor_application_status_page @assessor_application_status_page ||= PageObjects::AssessorInterface::ApplicationStatus.new end + def assessor_applications_page + @assessor_applications_page ||= + PageObjects::AssessorInterface::Applications.new + end + def assessor_assessment_recommendation_review_page @assessor_assessment_recommendation_review_page ||= PageObjects::AssessorInterface::AssessmentRecommendationReview.new end + def assessor_assessment_section_page + @assessor_assessment_section_page ||= + PageObjects::AssessorInterface::AssessmentSection.new + end + def assessor_assign_assessor_page @assessor_assign_assessor_page ||= PageObjects::AssessorInterface::AssignAssessor.new @@ -42,11 +47,6 @@ def assessor_assign_reviewer_page PageObjects::AssessorInterface::AssignReviewer.new end - def assessor_assessment_section_page - @assessor_assessment_section_page ||= - PageObjects::AssessorInterface::AssessmentSection.new - end - def assessor_check_english_language_proficiency_page @assessor_check_english_language_proficiency_page ||= PageObjects::AssessorInterface::CheckEnglishLanguageProficiency.new @@ -166,16 +166,16 @@ def assessor_qualification_requests_page PageObjects::AssessorInterface::QualificationRequests.new end - def assessor_reference_requests_page - @assessor_reference_requests_page ||= - PageObjects::AssessorInterface::ReferenceRequests.new - end - def assessor_reference_requests_assessment_recommendation_verify_page @assessor_reference_requests_assessment_recommendation_verify_page ||= PageObjects::AssessorInterface::ReferenceRequestsAssessmentRecommendationVerify.new end + def assessor_reference_requests_page + @assessor_reference_requests_page ||= + PageObjects::AssessorInterface::ReferenceRequests.new + end + def assessor_request_further_information_page @request_further_information_form = PageObjects::AssessorInterface::RequestFurtherInformation.new @@ -201,20 +201,15 @@ def assessor_review_verifications_page PageObjects::AssessorInterface::ReviewVerifications.new end - def assessor_timeline_page - @assessor_timeline_page ||= PageObjects::AssessorInterface::Timeline.new - end - - def assessor_verify_professional_standing_request_page - @assessor_verify_professional_standing_request_page ||= - PageObjects::AssessorInterface::VerifyProfessionalStandingRequest.new - end - def assessor_qualified_for_subject_page @assessor_qualified_for_subject_page ||= PageObjects::AssessorInterface::CreateNote.new end + def assessor_timeline_page + @assessor_timeline_page ||= PageObjects::AssessorInterface::Timeline.new + end + def assessor_verify_age_range_subjects_page @assessor_verify_age_range_subjects_page ||= PageObjects::AssessorInterface::VerifyAgeRangeSubjectsPage.new @@ -225,6 +220,11 @@ def assessor_verify_professional_standing_assessment_recommendation_verify_page PageObjects::AssessorInterface::VerifyProfessionalStandingAssessmentRecommendationVerify.new end + def assessor_verify_professional_standing_request_page + @assessor_verify_professional_standing_request_page ||= + PageObjects::AssessorInterface::VerifyProfessionalStandingRequest.new + end + def assessor_verify_qualifications_assessment_recommendation_verify_page @assessor_verify_qualifications_assessment_recommendation_verify_page ||= PageObjects::AssessorInterface::VerifyQualificationsAssessmentRecommendationVerify.new @@ -262,6 +262,11 @@ def eligibility_qualification_page PageObjects::EligibilityInterface::Qualification.new end + def eligibility_qualified_for_subject_page + @eligibility_qualified_for_subject_page ||= + PageObjects::EligibilityInterface::QualifiedForSubject.new + end + def eligibility_region_page @eligibility_region_page ||= PageObjects::EligibilityInterface::Region.new end @@ -275,11 +280,6 @@ def eligibility_teach_children_page PageObjects::EligibilityInterface::TeachChildren.new end - def eligibility_qualified_for_subject_page - @eligibility_qualified_for_subject_page ||= - PageObjects::EligibilityInterface::QualifiedForSubject.new - end - def eligibility_work_experience_page @eligibility_work_experience_page ||= PageObjects::EligibilityInterface::WorkExperience.new @@ -364,19 +364,14 @@ def teacher_check_qualifications_page PageObjects::TeacherInterface::CheckQualifications.new end - def teacher_check_uploaded_files_page - @teacher_check_uploaded_files_page = - PageObjects::TeacherInterface::CheckUploadedFiles.new - end - def teacher_check_reference_request_answers_page @teacher_check_reference_request_answers_page ||= PageObjects::TeacherInterface::CheckReferenceRequestAnswers.new end - def teacher_check_work_history_page - @teacher_check_work_history_page ||= - PageObjects::TeacherInterface::CheckWorkHistory.new + def teacher_check_uploaded_files_page + @teacher_check_uploaded_files_page = + PageObjects::TeacherInterface::CheckUploadedFiles.new end def teacher_check_work_histories_page @@ -384,6 +379,11 @@ def teacher_check_work_histories_page PageObjects::TeacherInterface::CheckWorkHistories.new end + def teacher_check_work_history_page + @teacher_check_work_history_page ||= + PageObjects::TeacherInterface::CheckWorkHistory.new + end + def teacher_check_your_answers_page @teacher_check_your_answers_page = PageObjects::TeacherInterface::CheckYourAnswers.new @@ -572,15 +572,6 @@ def teacher_signed_out_page @teacher_signed_out_page = PageObjects::TeacherInterface::SignedOut.new end - def teacher_subjects_page - @teacher_subjects_page = PageObjects::TeacherInterface::Subjects.new - end - - def teacher_submitted_application_page - @teacher_submitted_application_page = - PageObjects::TeacherInterface::SubmittedApplication.new - end - def teacher_sign_in_page @teacher_sign_in_page = PageObjects::TeacherInterface::SignIn.new end @@ -594,6 +585,15 @@ def teacher_sign_up_page @teacher_sign_up_page = PageObjects::TeacherInterface::SignUp.new end + def teacher_subjects_page + @teacher_subjects_page = PageObjects::TeacherInterface::Subjects.new + end + + def teacher_submitted_application_page + @teacher_submitted_application_page = + PageObjects::TeacherInterface::SubmittedApplication.new + end + def teacher_upload_document_page @teacher_upload_document_page = PageObjects::TeacherInterface::UploadDocument.new