From 1d1e0f33a7de11fe20e820e6e6aea63637e495fd Mon Sep 17 00:00:00 2001 From: Thomas Leese Date: Wed, 11 Oct 2023 13:19:22 +0100 Subject: [PATCH] Remove ready_for_review column It's not being used anywhere so we can remove this column. --- app/models/professional_standing_request.rb | 29 +++++++++---------- config/analytics.yml | 1 - ...iew_from_professional_standing_requests.rb | 11 +++++++ db/schema.rb | 3 +- .../professional_standing_requests.rb | 29 +++++++++---------- .../professional_standing_request_spec.rb | 29 +++++++++---------- 6 files changed, 54 insertions(+), 48 deletions(-) create mode 100644 db/migrate/20231011121802_remove_ready_for_review_from_professional_standing_requests.rb diff --git a/app/models/professional_standing_request.rb b/app/models/professional_standing_request.rb index ceff80f118..70e1210191 100644 --- a/app/models/professional_standing_request.rb +++ b/app/models/professional_standing_request.rb @@ -4,21 +4,20 @@ # # Table name: professional_standing_requests # -# id :bigint not null, primary key -# expired_at :datetime -# location_note :text default(""), not null -# ready_for_review :boolean default(FALSE), not null -# received_at :datetime -# requested_at :datetime -# review_note :string default(""), not null -# review_passed :boolean -# reviewed_at :datetime -# verified_at :datetime -# verify_note :text default(""), not null -# verify_passed :boolean -# created_at :datetime not null -# updated_at :datetime not null -# assessment_id :bigint not null +# id :bigint not null, primary key +# expired_at :datetime +# location_note :text default(""), not null +# received_at :datetime +# requested_at :datetime +# review_note :string default(""), not null +# review_passed :boolean +# reviewed_at :datetime +# verified_at :datetime +# verify_note :text default(""), not null +# verify_passed :boolean +# created_at :datetime not null +# updated_at :datetime not null +# assessment_id :bigint not null # # Indexes # diff --git a/config/analytics.yml b/config/analytics.yml index 9244b9cae4..fa2f68fd91 100644 --- a/config/analytics.yml +++ b/config/analytics.yml @@ -218,7 +218,6 @@ - expired_at - id - location_note - - ready_for_review - received_at - requested_at - review_note diff --git a/db/migrate/20231011121802_remove_ready_for_review_from_professional_standing_requests.rb b/db/migrate/20231011121802_remove_ready_for_review_from_professional_standing_requests.rb new file mode 100644 index 0000000000..280dced9cd --- /dev/null +++ b/db/migrate/20231011121802_remove_ready_for_review_from_professional_standing_requests.rb @@ -0,0 +1,11 @@ +class RemoveReadyForReviewFromProfessionalStandingRequests < ActiveRecord::Migration[ + 7.1 +] + def change + remove_column :professional_standing_requests, + :ready_for_review, + :boolean, + null: false, + default: false + end +end diff --git a/db/schema.rb b/db/schema.rb index a65158ae61..26990e5e3d 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.1].define(version: 2023_10_10_075849) do +ActiveRecord::Schema[7.1].define(version: 2023_10_11_121802) do # These are extensions that must be enabled in order to support this database enable_extension "pgcrypto" enable_extension "plpgsql" @@ -279,7 +279,6 @@ t.datetime "reviewed_at" t.boolean "review_passed" t.string "review_note", default: "", null: false - t.boolean "ready_for_review", default: false, null: false t.datetime "requested_at" t.datetime "expired_at" t.boolean "verify_passed" diff --git a/spec/factories/professional_standing_requests.rb b/spec/factories/professional_standing_requests.rb index 63b710a8af..cbd2893178 100644 --- a/spec/factories/professional_standing_requests.rb +++ b/spec/factories/professional_standing_requests.rb @@ -4,21 +4,20 @@ # # Table name: professional_standing_requests # -# id :bigint not null, primary key -# expired_at :datetime -# location_note :text default(""), not null -# ready_for_review :boolean default(FALSE), not null -# received_at :datetime -# requested_at :datetime -# review_note :string default(""), not null -# review_passed :boolean -# reviewed_at :datetime -# verified_at :datetime -# verify_note :text default(""), not null -# verify_passed :boolean -# created_at :datetime not null -# updated_at :datetime not null -# assessment_id :bigint not null +# id :bigint not null, primary key +# expired_at :datetime +# location_note :text default(""), not null +# received_at :datetime +# requested_at :datetime +# review_note :string default(""), not null +# review_passed :boolean +# reviewed_at :datetime +# verified_at :datetime +# verify_note :text default(""), not null +# verify_passed :boolean +# created_at :datetime not null +# updated_at :datetime not null +# assessment_id :bigint not null # # Indexes # diff --git a/spec/models/professional_standing_request_spec.rb b/spec/models/professional_standing_request_spec.rb index 2337990cf5..10993cc6cf 100644 --- a/spec/models/professional_standing_request_spec.rb +++ b/spec/models/professional_standing_request_spec.rb @@ -4,21 +4,20 @@ # # Table name: professional_standing_requests # -# id :bigint not null, primary key -# expired_at :datetime -# location_note :text default(""), not null -# ready_for_review :boolean default(FALSE), not null -# received_at :datetime -# requested_at :datetime -# review_note :string default(""), not null -# review_passed :boolean -# reviewed_at :datetime -# verified_at :datetime -# verify_note :text default(""), not null -# verify_passed :boolean -# created_at :datetime not null -# updated_at :datetime not null -# assessment_id :bigint not null +# id :bigint not null, primary key +# expired_at :datetime +# location_note :text default(""), not null +# received_at :datetime +# requested_at :datetime +# review_note :string default(""), not null +# review_passed :boolean +# reviewed_at :datetime +# verified_at :datetime +# verify_note :text default(""), not null +# verify_passed :boolean +# created_at :datetime not null +# updated_at :datetime not null +# assessment_id :bigint not null # # Indexes #