From c9bd9c6c8356fcc25e4c5561d7adfe675177626d Mon Sep 17 00:00:00 2001 From: plockwood Date: Mon, 28 Oct 2024 11:35:00 +0000 Subject: [PATCH 1/4] Fixes --- ...s => CreateCompleteConversionProjectSuccessResponse.cs} | 2 +- .../CreateCompleteTransferProjectSuccessResponse.cs | 6 ++++++ .../CreateCompleteConversionProjectsCommandHandlerTests.cs | 2 +- ...ompleteFormAMatConversionProjectsCommandHandlerTests.cs | 2 +- ...eCompleteFormAMatTransferProjectsCommandHandlerTests.cs | 2 +- .../CreateCompleteTransferProjectsCommandHandlerTests.cs | 2 +- .../CreateCompleteConversionProjectsCommandHandler.cs | 2 +- ...eateCompleteFormAMatConversionProjectsCommandHandler.cs | 2 +- ...CreateCompleteFormAMatTransferProjectsCommandHandler.cs | 4 ++-- .../CreateCompleteTransferProjectsCommandHandler.cs | 4 ++-- .../TransferProject/SetTransferProjectTrustCommand.cs | 1 + .../CompleteConversionProjectServiceModelMapper.cs | 7 ++++--- 12 files changed, 22 insertions(+), 14 deletions(-) rename Dfe.Academies.Academisation.IService/ServiceModels/Complete/{CreateCompleteProjectSuccessResponse.cs => CreateCompleteConversionProjectSuccessResponse.cs} (68%) create mode 100644 Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteTransferProjectSuccessResponse.cs diff --git a/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteProjectSuccessResponse.cs b/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteConversionProjectSuccessResponse.cs similarity index 68% rename from Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteProjectSuccessResponse.cs rename to Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteConversionProjectSuccessResponse.cs index 95580b75f..94aed4572 100644 --- a/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteProjectSuccessResponse.cs +++ b/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteConversionProjectSuccessResponse.cs @@ -6,7 +6,7 @@ namespace Dfe.Academies.Academisation.IService.ServiceModels.Complete { - public record CreateCompleteProjectSuccessResponse (Guid conversion_project_id) + public record CreateCompleteConversionProjectSuccessResponse (Guid conversion_project_id) { } } diff --git a/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteTransferProjectSuccessResponse.cs b/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteTransferProjectSuccessResponse.cs new file mode 100644 index 000000000..f70263791 --- /dev/null +++ b/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteTransferProjectSuccessResponse.cs @@ -0,0 +1,6 @@ +namespace Dfe.Academies.Academisation.IService.ServiceModels.Complete +{ + public record CreateCompleteTransferProjectSuccessResponse (Guid transfer_project_id) + { + } +} diff --git a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandlerTests.cs b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandlerTests.cs index b018e355b..dfc805c06 100644 --- a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandlerTests.cs +++ b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandlerTests.cs @@ -125,7 +125,7 @@ public async Task Handle_ConversionProjectsExist_SuccessfulResponse_ReturnsComma var command = _fixture.Create(); var conversionProjects = _fixture.CreateMany().ToList(); var advisoryDecision = _fixture.Create(); - var successResponse = _fixture.Create(); + var successResponse = _fixture.Create(); var projectGroup = _fixture.Create(); var mockContext = new Mock(); diff --git a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandlerTests.cs b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandlerTests.cs index 7ccdedc11..d2baa4b71 100644 --- a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandlerTests.cs +++ b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandlerTests.cs @@ -126,7 +126,7 @@ public async Task Handle_ConversionProjectsExist_SuccessfulResponse_ReturnsComma var command = _fixture.Create(); var conversionProjects = _fixture.CreateMany().ToList(); var advisoryDecision = _fixture.Create(); - var successResponse = _fixture.Create(); + var successResponse = _fixture.Create(); var projectGroup = _fixture.Create(); var mockContext = new Mock(); diff --git a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandlerTests.cs b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandlerTests.cs index a173bb69f..b74bf5b2f 100644 --- a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandlerTests.cs +++ b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandlerTests.cs @@ -160,7 +160,7 @@ public async Task Handle_ConversionProjectsExist_SuccessfulResponse_ReturnsComma } var advisoryDecision = _fixture.Create(); - var successResponse = _fixture.Create(); + var successResponse = _fixture.Create(); var projectGroup = _fixture.Create(); var mockContext = new Mock(); diff --git a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandlerTests.cs b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandlerTests.cs index 8d4bfead1..820ee0004 100644 --- a/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandlerTests.cs +++ b/Dfe.Academies.Academisation.Service.UnitTest/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandlerTests.cs @@ -156,7 +156,7 @@ public async Task Handle_ConversionProjectsExist_SuccessfulResponse_ReturnsComma } var advisoryDecision = _fixture.Create(); - var successResponse = _fixture.Create(); + var successResponse = _fixture.Create(); var projectGroup = _fixture.Create(); var mockContext = new Mock(); diff --git a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandler.cs b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandler.cs index fd5c900c9..3a8827f9b 100644 --- a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandler.cs +++ b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteConversionProjectsCommandHandler.cs @@ -83,7 +83,7 @@ public async Task Handle(CreateCompleteConversionProjectsCommand if (response.IsSuccessStatusCode) { - var successResponse = await response.Content.ReadFromJsonAsync(); + var successResponse = await response.Content.ReadFromJsonAsync(); completeProjectId = successResponse.conversion_project_id; _logger.LogInformation("Success sending conversion project to complete with project urn: {project} with Status code 201 ", completeObject.urn); diff --git a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandler.cs b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandler.cs index 2cd0ac37c..31c2c2659 100644 --- a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandler.cs +++ b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatConversionProjectsCommandHandler.cs @@ -86,7 +86,7 @@ public async Task Handle(CreateCompleteFormAMatConversionProjects if (response.IsSuccessStatusCode) { - var successResponse = await response.Content.ReadFromJsonAsync(); + var successResponse = await response.Content.ReadFromJsonAsync(); completeProjectId = successResponse.conversion_project_id; _logger.LogInformation("Success sending conversion project to complete with project urn: {project} with Status code 201 ", completeObject.urn); diff --git a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandler.cs b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandler.cs index f3516b16d..b6bcd19c2 100644 --- a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandler.cs +++ b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteFormAMatTransferProjectsCommandHandler.cs @@ -95,9 +95,9 @@ public async Task Handle(CreateCompleteFormAMatTransferProjectsCo if (response.IsSuccessStatusCode) { var successResponse = - await response.Content.ReadFromJsonAsync(); + await response.Content.ReadFromJsonAsync(); - completeProjectId = successResponse.conversion_project_id; + completeProjectId = successResponse.transfer_project_id; _logger.LogInformation( "Success sending transfer to complete with project urn: {project} with Status code 201 ", diff --git a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandler.cs b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandler.cs index 008c41e2b..135b8c87d 100644 --- a/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandler.cs +++ b/Dfe.Academies.Academisation.Service/Commands/CompleteProject/CreateCompleteTransferProjectsCommandHandler.cs @@ -103,9 +103,9 @@ public async Task Handle(CreateCompleteTransferProjectsCommand re if (response.IsSuccessStatusCode) { var successResponse = - await response.Content.ReadFromJsonAsync(); + await response.Content.ReadFromJsonAsync(); - completeProjectId = successResponse.conversion_project_id; + completeProjectId = successResponse.transfer_project_id; _logger.LogInformation( "Success sending transfer project to complete with project urn: {project} with Status code 201 ", diff --git a/Dfe.Academies.Academisation.Service/Commands/TransferProject/SetTransferProjectTrustCommand.cs b/Dfe.Academies.Academisation.Service/Commands/TransferProject/SetTransferProjectTrustCommand.cs index d90bcee70..201c5f446 100644 --- a/Dfe.Academies.Academisation.Service/Commands/TransferProject/SetTransferProjectTrustCommand.cs +++ b/Dfe.Academies.Academisation.Service/Commands/TransferProject/SetTransferProjectTrustCommand.cs @@ -8,5 +8,6 @@ public class SetTransferProjectTrustCommand : SetTransferProjectCommand { public string ProjectName { get; set; } public string? IncomingTrustUKPRN { get; set; } + public string? IncomingTrustReferenceNumber { get; set; } } } diff --git a/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteConversionProjectServiceModelMapper.cs b/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteConversionProjectServiceModelMapper.cs index 69c41b644..73eaae123 100644 --- a/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteConversionProjectServiceModelMapper.cs +++ b/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteConversionProjectServiceModelMapper.cs @@ -1,4 +1,5 @@ -using Dfe.Academies.Academisation.IDomain.ConversionAdvisoryBoardDecisionAggregate; +using System; +using Dfe.Academies.Academisation.IDomain.ConversionAdvisoryBoardDecisionAggregate; using Dfe.Academies.Academisation.IDomain.ProjectAggregate; using Dfe.Academies.Academisation.IDomain.TransferProjectAggregate; using Dfe.Academies.Academisation.IService.ServiceModels.Complete; @@ -22,7 +23,7 @@ internal static CompleteConversionProjectServiceModel FromDomain(IProject projec project.Details.HeadTeacherBoardDate.ToString(), conditions, project.Details.ProposedConversionDate.ToString(), - true, + project.Details.AcademyTypeAndRoute?.Equals("Sponsored") ?? false, email, firstName, lastName, @@ -47,7 +48,7 @@ internal static CompleteFormAMatConversionProjectServiceModel FormAMatFromDomain project.Details.HeadTeacherBoardDate.ToString(), conditions, project.Details.ProposedConversionDate.ToString(), - true, + project.Details.AcademyTypeAndRoute?.Equals("Sponsored") ?? false, email, firstName, lastName, From eb4469ae7dab5eb9fee1093fef628faa87e005f5 Mon Sep 17 00:00:00 2001 From: danielryannimble Date: Mon, 28 Oct 2024 20:59:15 +0000 Subject: [PATCH 2/4] new trust name and reference number added to error response --- .vscode/launch.json | 35 ++++++++++++++++ .vscode/tasks.json | 41 +++++++++++++++++++ .../CreateCompleteProjectErrorResponse.cs | 12 +++++- ...mpleteTransferProjectServiceModelMapper.cs | 2 +- .../Services/CreateCompleteProjectsService.cs | 1 + 5 files changed, 89 insertions(+), 2 deletions(-) create mode 100644 .vscode/launch.json create mode 100644 .vscode/tasks.json diff --git a/.vscode/launch.json b/.vscode/launch.json new file mode 100644 index 000000000..cbb709491 --- /dev/null +++ b/.vscode/launch.json @@ -0,0 +1,35 @@ +{ + "version": "0.2.0", + "configurations": [ + { + // Use IntelliSense to find out which attributes exist for C# debugging + // Use hover for the description of the existing attributes + // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md + "name": ".NET Core Launch (web)", + "type": "coreclr", + "request": "launch", + "preLaunchTask": "build", + // If you have changed target frameworks, make sure to update the program path. + "program": "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/bin/Debug/net6.0/Dfe.Academies.Academisation.WebApi.dll", + "args": [], + "cwd": "${workspaceFolder}/Dfe.Academies.Academisation.WebApi", + "stopAtEntry": false, + // Enable launching a web browser when ASP.NET Core starts. For more information: https://aka.ms/VSCode-CS-LaunchJson-WebBrowser + "serverReadyAction": { + "action": "openExternally", + "pattern": "\\bNow listening on:\\s+(https?://\\S+)" + }, + "env": { + "ASPNETCORE_ENVIRONMENT": "Development" + }, + "sourceFileMap": { + "/Views": "${workspaceFolder}/Views" + } + }, + { + "name": ".NET Core Attach", + "type": "coreclr", + "request": "attach" + } + ] +} \ No newline at end of file diff --git a/.vscode/tasks.json b/.vscode/tasks.json new file mode 100644 index 000000000..612e38c84 --- /dev/null +++ b/.vscode/tasks.json @@ -0,0 +1,41 @@ +{ + "version": "2.0.0", + "tasks": [ + { + "label": "build", + "command": "dotnet", + "type": "process", + "args": [ + "build", + "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/Dfe.Academies.Academisation.WebApi.csproj", + "/property:GenerateFullPaths=true", + "/consoleloggerparameters:NoSummary" + ], + "problemMatcher": "$msCompile" + }, + { + "label": "publish", + "command": "dotnet", + "type": "process", + "args": [ + "publish", + "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/Dfe.Academies.Academisation.WebApi.csproj", + "/property:GenerateFullPaths=true", + "/consoleloggerparameters:NoSummary" + ], + "problemMatcher": "$msCompile" + }, + { + "label": "watch", + "command": "dotnet", + "type": "process", + "args": [ + "watch", + "run", + "--project", + "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/Dfe.Academies.Academisation.WebApi.csproj" + ], + "problemMatcher": "$msCompile" + } + ] +} \ No newline at end of file diff --git a/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteProjectErrorResponse.cs b/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteProjectErrorResponse.cs index 506745f3e..f7c9a2e38 100644 --- a/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteProjectErrorResponse.cs +++ b/Dfe.Academies.Academisation.IService/ServiceModels/Complete/CreateCompleteProjectErrorResponse.cs @@ -35,7 +35,9 @@ public string GetAllErrors() ValidationErrors.InadequateOfsted?.Select(e => $"inadequate_ofsted: {e.Error}"), ValidationErrors.FinancialSafeguardingGovernanceIssues?.Select(e => $"financial_safeguarding_governance_issues: {e.Error}"), ValidationErrors.OutgoingTrustToClose?.Select(e => $"outgoing_trust_to_close: {e.Error}"), - ValidationErrors.OutgoingTrustUkprn?.Select(e => $"outgoing_trust_to_close: {e.Error}"), + ValidationErrors.OutgoingTrustUkprn?.Select(e => $"outgoing_trust_ukprn: {e.Error}"), + ValidationErrors.NewTrustReferenceNumber?.Select(e => $"new_trust_reference_number: {e.Error}"), + ValidationErrors.NewTrustName?.Select(e => $"new_trust_name: {e.Error}"), }; @@ -110,6 +112,14 @@ public class ValidationErrors [JsonPropertyName("outgoing_trust_ukprn")] public List OutgoingTrustUkprn { get; set; } + + [JsonPropertyName("new_trust_reference_number")] + + public List NewTrustReferenceNumber { get; set; } + + [JsonPropertyName("new_trust_name")] + + public List NewTrustName { get; set; } } public class ErrorDetail diff --git a/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteTransferProjectServiceModelMapper.cs b/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteTransferProjectServiceModelMapper.cs index 9e0e04c06..feca23eae 100644 --- a/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteTransferProjectServiceModelMapper.cs +++ b/Dfe.Academies.Academisation.Service/Mappers/CompleteProjects/CompleteTransferProjectServiceModelMapper.cs @@ -81,7 +81,7 @@ internal static CompleteFormAMatTransferProjectServiceModel FormAMatFromDomain(I // Transfer projects aren't currently added to groups null, // Need the trust reference number, proposed trust name is held in the incoming trust name field - "TrustReferenceNumber", + "trustreferencenumber", incomingName ); } diff --git a/Dfe.Academies.Academisation.WebApi/Services/CreateCompleteProjectsService.cs b/Dfe.Academies.Academisation.WebApi/Services/CreateCompleteProjectsService.cs index 90bb93958..487c97d7e 100644 --- a/Dfe.Academies.Academisation.WebApi/Services/CreateCompleteProjectsService.cs +++ b/Dfe.Academies.Academisation.WebApi/Services/CreateCompleteProjectsService.cs @@ -41,6 +41,7 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken) await mediator.Send(new CreateCompleteConversionProjectsCommand(), stoppingToken); await mediator.Send(new CreateCompleteTransferProjectsCommand(), stoppingToken); await mediator.Send(new CreateCompleteFormAMatConversionProjectsCommand(), stoppingToken); + //await mediator.Send(new CreateCompleteFormAMatTransferProjectsCommand(), stoppingToken); } catch (Exception ex) { From ef3b5f9d69d3f903c43015b5736a7f0cb14b4fc7 Mon Sep 17 00:00:00 2001 From: plockwood Date: Tue, 29 Oct 2024 10:46:25 +0000 Subject: [PATCH 3/4] removed vscode settings --- .vscode/launch.json | 35 ----------------------------------- .vscode/settings.json | 3 --- .vscode/tasks.json | 41 ----------------------------------------- 3 files changed, 79 deletions(-) delete mode 100644 .vscode/launch.json delete mode 100644 .vscode/settings.json delete mode 100644 .vscode/tasks.json diff --git a/.vscode/launch.json b/.vscode/launch.json deleted file mode 100644 index cbb709491..000000000 --- a/.vscode/launch.json +++ /dev/null @@ -1,35 +0,0 @@ -{ - "version": "0.2.0", - "configurations": [ - { - // Use IntelliSense to find out which attributes exist for C# debugging - // Use hover for the description of the existing attributes - // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md - "name": ".NET Core Launch (web)", - "type": "coreclr", - "request": "launch", - "preLaunchTask": "build", - // If you have changed target frameworks, make sure to update the program path. - "program": "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/bin/Debug/net6.0/Dfe.Academies.Academisation.WebApi.dll", - "args": [], - "cwd": "${workspaceFolder}/Dfe.Academies.Academisation.WebApi", - "stopAtEntry": false, - // Enable launching a web browser when ASP.NET Core starts. For more information: https://aka.ms/VSCode-CS-LaunchJson-WebBrowser - "serverReadyAction": { - "action": "openExternally", - "pattern": "\\bNow listening on:\\s+(https?://\\S+)" - }, - "env": { - "ASPNETCORE_ENVIRONMENT": "Development" - }, - "sourceFileMap": { - "/Views": "${workspaceFolder}/Views" - } - }, - { - "name": ".NET Core Attach", - "type": "coreclr", - "request": "attach" - } - ] -} \ No newline at end of file diff --git a/.vscode/settings.json b/.vscode/settings.json deleted file mode 100644 index c6ab0ff0d..000000000 --- a/.vscode/settings.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "dotnet.defaultSolution": "Dfe.Academies.Academisation.sln" -} \ No newline at end of file diff --git a/.vscode/tasks.json b/.vscode/tasks.json deleted file mode 100644 index 612e38c84..000000000 --- a/.vscode/tasks.json +++ /dev/null @@ -1,41 +0,0 @@ -{ - "version": "2.0.0", - "tasks": [ - { - "label": "build", - "command": "dotnet", - "type": "process", - "args": [ - "build", - "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/Dfe.Academies.Academisation.WebApi.csproj", - "/property:GenerateFullPaths=true", - "/consoleloggerparameters:NoSummary" - ], - "problemMatcher": "$msCompile" - }, - { - "label": "publish", - "command": "dotnet", - "type": "process", - "args": [ - "publish", - "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/Dfe.Academies.Academisation.WebApi.csproj", - "/property:GenerateFullPaths=true", - "/consoleloggerparameters:NoSummary" - ], - "problemMatcher": "$msCompile" - }, - { - "label": "watch", - "command": "dotnet", - "type": "process", - "args": [ - "watch", - "run", - "--project", - "${workspaceFolder}/Dfe.Academies.Academisation.WebApi/Dfe.Academies.Academisation.WebApi.csproj" - ], - "problemMatcher": "$msCompile" - } - ] -} \ No newline at end of file From d3b4b8ad476f5cd2e10a7c9436384db2018d99b7 Mon Sep 17 00:00:00 2001 From: plockwood Date: Tue, 29 Oct 2024 11:54:06 +0000 Subject: [PATCH 4/4] default sending projects to complete to false --- Dfe.Academies.Academisation.WebApi/appsettings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dfe.Academies.Academisation.WebApi/appsettings.json b/Dfe.Academies.Academisation.WebApi/appsettings.json index 91a9ea8b5..e344f762e 100644 --- a/Dfe.Academies.Academisation.WebApi/appsettings.json +++ b/Dfe.Academies.Academisation.WebApi/appsettings.json @@ -23,5 +23,5 @@ "TransferCreation": "", "SuperAdmin": "" }, - "SendProjectsToComplete" : "true" + "SendProjectsToComplete" : "false" }