From 9d2b1991e2c7e3a06da1c41e8bc1dba9fedca05e Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 13 Jan 2023 23:18:41 +0000 Subject: [PATCH] [bot] ms3 review of all scores (tests failed) --- harmonies/csv-metadata.json | 4 ++-- measures/csv-metadata.json | 4 ++-- notes/csv-metadata.json | 4 ++-- warnings.log | 8 ++++---- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/harmonies/csv-metadata.json b/harmonies/csv-metadata.json index 72638b31..474e2b76 100644 --- a/harmonies/csv-metadata.json +++ b/harmonies/csv-metadata.json @@ -10,7 +10,7 @@ "delimiter": "\t" }, "dc:description": "One feature matrix per score, containing one line per label. The first columns (until 'label') are the same as in extracted 'labels' tables with the difference that only those harmony labels that match the DCML harmony annotation standard (dcmlab.github.io/standards) are included. Since these follow a specific syntax, they can be split into their components (features) and transformed into scale degrees. For more information, please refer to the docs at https://johentsch.github.io/ms3/columns", - "dc:created": "2022-12-22T15:56:48", + "dc:created": "2023-01-13T23:18:12", "dc:creator": [ { "@context": "https://schema.org/", @@ -22,7 +22,7 @@ "name": "Johannes Hentschel", "@id": "https://orcid.org/0000-0002-1986-9545" }, - "softwareVersion": "1.0.4" + "softwareVersion": "1.1.1" } ], "tables": [ diff --git a/measures/csv-metadata.json b/measures/csv-metadata.json index 2bc8bf00..e52f2857 100644 --- a/measures/csv-metadata.json +++ b/measures/csv-metadata.json @@ -10,7 +10,7 @@ "delimiter": "\t" }, "dc:description": "One feature matrix per score, containing one line per stack of tags in the score's XML tree. They are counted in the column 'mc' starting from 1, whereas the conventional measure numbers are shown in the column 'mn'. One MN is frequently composed in two (or more) MCs. Furthermore, these tables include special bar lines, repeat signs, first and second endings, irregular measure lengths, as well as the column 'next' which contains follow-up MCs for unfolding a score's repeat structure. For more information, please refer to the docs at https://johentsch.github.io/ms3/columns", - "dc:created": "2022-12-22T15:56:48", + "dc:created": "2023-01-13T23:18:12", "dc:creator": [ { "@context": "https://schema.org/", @@ -22,7 +22,7 @@ "name": "Johannes Hentschel", "@id": "https://orcid.org/0000-0002-1986-9545" }, - "softwareVersion": "1.0.4" + "softwareVersion": "1.1.1" } ], "tables": [ diff --git a/notes/csv-metadata.json b/notes/csv-metadata.json index aed6945f..49555587 100644 --- a/notes/csv-metadata.json +++ b/notes/csv-metadata.json @@ -10,7 +10,7 @@ "delimiter": "\t" }, "dc:description": "One feature matrix per score, containing one row per note head. Not every row represents an onset because note heads may be tied together (see column 'tied'). For more information, please refer to the docs at https://johentsch.github.io/ms3/columns", - "dc:created": "2022-12-22T15:56:48", + "dc:created": "2023-01-13T23:18:12", "dc:creator": [ { "@context": "https://schema.org/", @@ -22,7 +22,7 @@ "name": "Johannes Hentschel", "@id": "https://orcid.org/0000-0002-1986-9545" }, - "softwareVersion": "1.0.4" + "softwareVersion": "1.1.1" } ], "tables": [ diff --git a/warnings.log b/warnings.log index 5f54b51a..3b559af3 100644 --- a/warnings.log +++ b/warnings.log @@ -1,16 +1,16 @@ Warnings encountered during the last execution of ms3 review (v1.1.1) ===================================================================== +DCML_SEVENTH_CORD_WITH_ALTERED_SEVENTH_WARNING (18,) ms3.Parse.medtner_tales.op08n01 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4194) features2tpcs(): + MC 41: In seventh chords, such as V43(7b5), it is not clear whether the 7 alters the 7 or replaces the 8 and should not be used. DCML_DEFAULT_CORRECTION_WARNING (27, 'MC 48: ') ms3.Parse.medtner_tales.op08n01 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4066) features2tpcs(): MC 48: #vii in major context corrected to vii. DCML_SEVENTH_CORD_WITH_ALTERED_SEVENTH_WARNING (18,) ms3.Parse.medtner_tales.op08n01 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4194) features2tpcs(): MC 43: In seventh chords, such as V43(7b5), it is not clear whether the 7 alters the 7 or replaces the 8 and should not be used. -DCML_SEVENTH_CORD_WITH_ALTERED_SEVENTH_WARNING (18,) ms3.Parse.medtner_tales.op08n01 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4194) features2tpcs(): - MC 41: In seventh chords, such as V43(7b5), it is not clear whether the 7 alters the 7 or replaces the 8 and should not be used. -DCML_HARMONY_SUPERFLUOUS_TONE_REPLACEMENT_WARNING (6, 52, 'V7(b96b5)') ms3.Parse.medtner_tales.op26n03 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4227) features2tpcs(): - MC 52: V7(b96b5) results in a chord tone 5th AND its replacement(s) (TPC [0]). You might want to add a + to distinguish from a suspension, or add this warning to IGNORED_WARNINGS with a comment. DCML_HARMONY_SUPERFLUOUS_TONE_REPLACEMENT_WARNING (6, 48, 'V7(b96b5)') ms3.Parse.medtner_tales.op26n03 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4227) features2tpcs(): MC 48: V7(b96b5) results in a chord tone 5th AND its replacement(s) (TPC [0]). You might want to add a + to distinguish from a suspension, or add this warning to IGNORED_WARNINGS with a comment. +DCML_HARMONY_SUPERFLUOUS_TONE_REPLACEMENT_WARNING (6, 52, 'V7(b96b5)') ms3.Parse.medtner_tales.op26n03 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4227) features2tpcs(): + MC 52: V7(b96b5) results in a chord tone 5th AND its replacement(s) (TPC [0]). You might want to add a + to distinguish from a suspension, or add this warning to IGNORED_WARNINGS with a comment. DCML_DEFAULT_CORRECTION_WARNING (27, 'MC 34: ') ms3.Parse.medtner_tales.op26n04 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 4066) features2tpcs(): MC 34: #vii in major context corrected to vii. DCML_PHRASE_INCONGRUENCY_WARNING (16,) ms3.Parse.medtner_tales.op26n04 -- /usr/local/lib/python3.10/site-packages/ms3/utils.py (line 5016) check_phrase_annotations():