Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove top-level calls to pip_install #65

Open
jcfr opened this issue Dec 20, 2023 · 2 comments
Open

⚠️ Remove top-level calls to pip_install #65

jcfr opened this issue Dec 20, 2023 · 2 comments

Comments

@jcfr
Copy link
Contributor

jcfr commented Dec 20, 2023

Packages should NOT be installed simply after importing the script.

Additionally, the user should be notified that their installation will be modified and offered the option to opt-out.

See https://slicer.readthedocs.io/en/latest/developer_guide/python_faq.html#can-i-use-any-python-package-in-a-slicer-module

@jcfr jcfr changed the title ⚠️ Remove top-level call to pip_install ⚠️ Remove top-level calls to pip_install Dec 20, 2023
@jcfr
Copy link
Contributor Author

jcfr commented Dec 20, 2023

re: #59

@Jeanneclre
Copy link
Contributor

Jeanneclre commented Dec 22, 2023

Hello @jcfr

Thank you for your input.
I was looking into the best way to do it for AREG, re: #61 but I've read the doc you sent and I don't exactly understand how we have to install the package in practice. Should we add a function that is called when running our module (at the start of the process) or should it be a file such as a requirement.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants