Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to -m4-single #40

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch to -m4-single #40

wants to merge 1 commit into from

Conversation

MastaG
Copy link
Contributor

@MastaG MastaG commented Aug 20, 2024

I can confirm that it fully builds everything.
However do not merge it until I have tested it later this week.

@MastaG MastaG marked this pull request as draft August 20, 2024 11:14
@MastaG MastaG changed the title [WIP] Switch to -m4-single Switch to -m4-single Aug 22, 2024
@MastaG MastaG marked this pull request as ready for review August 22, 2024 07:45
@MastaG
Copy link
Contributor Author

MastaG commented Aug 22, 2024

@DC-SWAT I didn't find any regressions building with -m4-single instead of -m4-single-only.
Perhaps just leave this open until KOS switches to -m4-single by default, then we can merge it.
This way we can stay as close to KOS defaults as possible.

@MastaG
Copy link
Contributor Author

MastaG commented Aug 26, 2024

I have did lots of testing and couldn't find any stability problems with this PR.
The crashes at the games menu are also there without my PR, it's still WIP.
Same goes for the crash when entering and exiting the "GD Play" menu without any disc inserted.

@DC-SWAT
Copy link
Owner

DC-SWAT commented Sep 2, 2024

I think it's worth waiting for KOS to switch to this by default. Because I try to keep the code as close to the default KOS as possible.
Also I was told that this mode will not be removed from the GCC.

@MastaG
Copy link
Contributor Author

MastaG commented Sep 4, 2024

absolutely, I just wanted to mention that I couldn't find any issues.
I will rebase this once kos switches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants