Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Incorrect model equations after model-edit #6234

Open
mwdchang opened this issue Jan 24, 2025 · 0 comments
Open

[BUG]: Incorrect model equations after model-edit #6234

mwdchang opened this issue Jan 24, 2025 · 0 comments
Assignees
Labels
bug Something isn't working Q&A Quality Assurance

Comments

@mwdchang
Copy link
Member

Starting with an SIR model, I used model edit to add a new transition between S and R, with some new parameter v.

The model generated seemed to be fine:

Image

But the equations show seem to be messed up.

Image

One would expect, for example, that dS/dt to be:

dS/dt = -S*v - beta * S * I

But is shown to be just -v which I don't think is correct, it shouldn't be a constant.

Scenario: https://github.com/DARPA-ASKEM/terarium/blob/main/testing/manual/model-edit.md
Link: https://app.staging.terarium.ai/projects/0f476a43-f7d4-433b-bee6-e853dba06522/workflow/d8e8c03c-1fec-45fc-adc9-8ffba8139eec?operator=d3045405-705b-4606-aed7-fdb8a9d60dee

@mwdchang mwdchang added bug Something isn't working Q&A Quality Assurance labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Q&A Quality Assurance
Projects
None yet
Development

No branches or pull requests

2 participants