Fix Press and support cross-chain Presses #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt Stargaze DAOs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
CLHRAE
approved these changes
Nov 9, 2023
JakeHartnell
approved these changes
Nov 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1449
Press was previously changed to use
instantiate2even though pre-propose contracts don't support that yet. This changes Press back to using an NFT contract pre-created by the wallet.To support Stargaze DAOs, since NFTs work differently on Stargaze, this now allows setting up Press to use an NFT contract on any polytone-connected chain. Eventually we should integrate Press into the Stargaze NFT ecosystem, but that is a significantly amount of work and no one is asking for it right now.