Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when parent DAO is chain module #1368

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

NoahSaso
Copy link
Member

@NoahSaso NoahSaso commented Sep 7, 2023

Resolves #1098

This detects when a DAO's parent/admin is set to a chain module account (like x/gov or x/distribution for the community pool) and shows a chain image/links to the chain governance page where the parent DAO is typically shown.

This also moves the admin image to the top left instead of the bottom right.

Screenshot 2023-09-06 at 17 36 08 Screenshot 2023-09-06 at 17 36 26 Screenshot 2023-09-06 at 17 36 34

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dapp-legacy 🔄 Building (Inspect) Visit Preview Sep 7, 2023 0:36am
dapp-mainnet 🔄 Building (Inspect) Visit Preview Sep 7, 2023 0:36am
dapp-testnet 🔄 Building (Inspect) Visit Preview Sep 7, 2023 0:36am
sda-mainnet 🔄 Building (Inspect) Visit Preview Sep 7, 2023 0:36am
sda-testnet 🔄 Building (Inspect) Visit Preview Sep 7, 2023 0:36am

@NoahSaso NoahSaso merged commit e02c228 into development Sep 7, 2023
2 checks passed
@NoahSaso NoahSaso deleted the noah/gov-subdao-parent branch September 7, 2023 00:51
NoahSaso added a commit that referenced this pull request Sep 7, 2023
* Disable self-relay between Juno and Stargaze. (#1365)

* Minor design improvements (#1366)

* Fix extra footer on non-polytone proposals.

* Improve design and responsiveness of treasury page.

* Recognize when a DAO admin is a chain module account and show gov as parent DAO. (#1368)

* Swap out indexer URLs and fix websockets for inbox (#1370)

* Swap indexer URLs.

* Subscribe inbox to all following DAOs instead of just those with currently open proposals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight Juno SubDAOs
2 participants