Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish cw-orch integration #846

Merged
merged 59 commits into from
Aug 14, 2024

Conversation

ismellike
Copy link
Contributor

@ismellike ismellike commented Jul 11, 2024

Continuation of #831

  • Fixes merge conflicts
  • Fixes lints
  • Adds wasm_test feature to test_contracts/tests.rs to avoid wasm build from basic.yml
  • Fixes schema diff
  • Adds #[cfg(not(target_arch = "wasm32"))] to cw_orch contracts for wasm compilation in basic.yml
  • Bumps workspace optimizer version to 0.16.0

Bonus:

  • Updates just lint to match basic.yml commands

@ismellike ismellike marked this pull request as draft July 11, 2024 06:38
@ismellike ismellike marked this pull request as ready for review July 11, 2024 07:48
@JakeHartnell
Copy link
Member

Looking good, just need to get CI to pass. 💪

@ismellike ismellike marked this pull request as draft July 24, 2024 07:26
@ismellike ismellike marked this pull request as ready for review July 24, 2024 17:28
@ismellike
Copy link
Contributor Author

Ok we should be good now.
@hard-nett latest changes were to establish a centralized framework for testing in /scripts
https://orchestrator.abstract.money/setup/workspace/setup.html#final-project-structure

@ismellike
Copy link
Contributor Author

any suggestions for fixing the test-tube integration tests running out of space?

@hard-nett
Copy link
Contributor

any suggestions for fixing the test-tube integration tests running out of space?

not too sure for getting around the ci vm error, but would you agree we can now replace the test-tube logic with cw-orch entirely?

@ismellike
Copy link
Contributor Author

any suggestions for fixing the test-tube integration tests running out of space?

not too sure for getting around the ci vm error, but would you agree we can now replace the test-tube logic with cw-orch entirely?

Definitely. This should help us get everything on the same version as well, and it should help with the CI storage issue.

@JakeHartnell JakeHartnell merged commit ba4e04c into DA0-DA0:development Aug 14, 2024
3 of 4 checks passed
JakeHartnell added a commit that referenced this pull request Aug 14, 2024
NoahSaso pushed a commit that referenced this pull request Aug 14, 2024
@JakeHartnell JakeHartnell mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants