More test coverage

DA0-DA0 · Aug 20, 2023 · 319e8ba · 319e8ba
1 parent cb37559
commit 319e8ba
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 2 deletions.
diff --git a/contracts/voting/dao-voting-native-staked/src/tests.rs b/contracts/voting/dao-voting-native-staked/src/tests.rs
@@ -1306,14 +1306,39 @@ fn test_update_active_threshold() {
 
     let resp: ActiveThresholdResponse = app
         .wrap()
-        .query_wasm_smart(addr, &QueryMsg::ActiveThreshold {})
+        .query_wasm_smart(addr.clone(), &QueryMsg::ActiveThreshold {})
         .unwrap();
     assert_eq!(
         resp.active_threshold,
         Some(ActiveThreshold::AbsoluteCount {
             count: Uint128::new(100)
         })
     );
+
+    // Can't set threshold to invalid value
+    let msg = ExecuteMsg::UpdateActiveThreshold {
+        new_threshold: Some(ActiveThreshold::Percentage {
+            percent: Decimal::percent(120),
+        }),
+    };
+    let err: ContractError = app
+        .execute_contract(Addr::unchecked(DAO_ADDR), addr.clone(), &msg, &[])
+        .unwrap_err()
+        .downcast()
+        .unwrap();
+    assert_eq!(err, ContractError::InvalidActivePercentage {});
+
+    // Remove threshold
+    let msg = ExecuteMsg::UpdateActiveThreshold {
+        new_threshold: None,
+    };
+    app.execute_contract(Addr::unchecked(DAO_ADDR), addr.clone(), &msg, &[])
+        .unwrap();
+    let resp: ActiveThresholdResponse = app
+        .wrap()
+        .query_wasm_smart(addr, &QueryMsg::ActiveThreshold {})
+        .unwrap();
+    assert_eq!(resp.active_threshold, None);
 }
 
 #[test]

diff --git a/packages/cw-hooks/src/lib.rs b/packages/cw-hooks/src/lib.rs
@@ -189,8 +189,16 @@ mod tests {
             )]
         );
 
+        // Query hooks returns all hooks added
         let HooksResponse { hooks: the_hooks } = hooks.query_hooks(deps.as_ref()).unwrap();
-
         assert_eq!(the_hooks, vec![addr!("meow")]);
+
+        // Remove last hook
+        hooks.remove_hook(&mut deps.storage, addr!("meow")).unwrap();
+
+        // Query hooks returns empty vector if no hooks added
+        let HooksResponse { hooks: the_hooks } = hooks.query_hooks(deps.as_ref()).unwrap();
+        let no_hooks: Vec<String> = vec![];
+        assert_eq!(the_hooks, no_hooks);
     }
 }