Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Removed core scroll page up button handling #423

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix(ui): Removed core scroll page up button handling #423

wants to merge 1 commit into from

Conversation

amanCypherock
Copy link
Contributor

@amanCypherock amanCypherock added the bugfix This change fix something that's not working as expected label Oct 14, 2023
@amanCypherock amanCypherock self-assigned this Oct 14, 2023
@rohanagarwal94
Copy link

Task linked: PRF-6206 On device confirmation screen focus goes away from the display

2 similar comments
@rohanagarwal94
Copy link

Task linked: PRF-6206 On device confirmation screen focus goes away from the display

@rohanagarwal94
Copy link

Task linked: PRF-6206 On device confirmation screen focus goes away from the display

@amanCypherock amanCypherock force-pushed the fix/shadow-focus-core-scroll-page/PRF-6206 branch from 2344166 to 35cd7f4 Compare October 14, 2023 10:14
@amanCypherock amanCypherock force-pushed the fix/shadow-focus-core-scroll-page/PRF-6206 branch from 35cd7f4 to 5982fed Compare October 14, 2023 10:15
ujjwal-cyph
ujjwal-cyph requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@ujjwal-cyph ujjwal-cyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when buttons are made visible all the time, the focus never goes to the buttons (except on the last page). make sure all the pages allow focusing on the buttons.

@ujjwal-cyph
Copy link
Collaborator

converting to draft as the change needs further discussion.

@ujjwal-cyph ujjwal-cyph marked this pull request as draft October 20, 2023 09:58
@amanCypherock amanCypherock changed the title fix(ui): Remvoed core scroll page up button handling fix(ui): Removed core scroll page up button handling Oct 20, 2023
Base automatically changed from refactor/core-framework to develop December 27, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjwal-cyph ujjwal-cyph ujjwal-cyph requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@amanCypherock amanCypherock

Labels
bugfix This change fix something that's not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanCypherock @rohanagarwal94 @ujjwal-cyph