Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.3.3 Staging #754

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

v0.3.3 Staging #754

wants to merge 25 commits into from

Conversation

TilakMaddy
Copy link
Collaborator

@TilakMaddy TilakMaddy commented Oct 4, 2024 •
edited
Loading

Features

Fixes

  • Account for revert statements not just revert functions in require/revert in loop detector
  • Catch only ERC20 functions when reporting unsafe transfer

Modifications

  • Lower the severity of UncheckedReturn detector
  • Lower the severity of block.timestamp in deadline detector
  • Lower the severity of delegate call in loop detector
  • Arbitrary transfer from has a new strategy

Removed

  • Uninitialized state variable detector

Funding

  • Create funding.json for gitcoin

TilakMaddy and others added 9 commits October 3, 2024 11:29
@TilakMaddy
Allow for sendValue on address to be recognized as a withdraw funct…
9207635 
…ion (#748)
@TilakMaddy @alexroan
Relax fixed pragma constraints on library contract files (#740)
ceee00e 
Co-authored-by: Alex Roan <[email protected]>
@TilakMaddy
Fix: Allow aderyn to exit without crashing if update-check fails (#753)
69a4d5a
@TilakMaddy
Rename ConstantsInsteadOfLiterals detector to better suit `//aderyn…
c270c08 
…-ignore-(..)` (#737)
@Ritik-Agarwal50 @alexroan @TilakMaddy
Fixed typo adress -> address (#741)
ae3ed55 
Co-authored-by: Alex Roan <[email protected]>
Co-authored-by: Tilak Madichetti <[email protected]>
@TilakMaddy
Revise detector names to be semantically correct with the `//aderyn-i…
8d5fdc3 
…gnore..` pattern (#739)
@TilakMaddy @alexroan
Low Detector: State variable could be marked immutable + Inter Contex…
ccc8ac1 
…t Merge Strategy (#734)

Co-authored-by: Alex Roan <[email protected]>
@TilakMaddy
standardize rust formatting with rustfmt.toml (#755)
748ae7f
@TilakMaddy
feat: Add refactor commit to blame-ingore-revs (#756)
0279da5
@TilakMaddy TilakMaddy changed the title Staging v0.3.1 v0.3.1 Staging Oct 10, 2024
@TilakMaddy TilakMaddy changed the title v0.3.1 Staging v0.3.1 Staging Oct 10, 2024
@TilakMaddy TilakMaddy marked this pull request as ready for review October 10, 2024 11:22
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner October 10, 2024 11:22
@TilakMaddy TilakMaddy marked this pull request as draft October 10, 2024 12:00
@TilakMaddy TilakMaddy changed the title v0.3.1 Staging v0.3.1 & v0.3.2 Staging Oct 10, 2024
@TilakMaddy TilakMaddy changed the title v0.3.1 & v0.3.2 Staging v0.3.3 Staging Oct 10, 2024
mgiagante and others added 11 commits October 12, 2024 11:49
@mgiagante @TilakMaddy
Implements init subcommand with optional path for aderyn.toml (#762)
47792bf 
Co-authored-by: mgiagante <[email protected]>
Co-authored-by: TilakMaddy <[email protected]>
@TilakMaddy
Create funding.json (#765)
86100ab
@TilakMaddy
Lower the severity of unchecked return detector (#766)
f872928
@TilakMaddy
Fix unchecked return detector test (#768)
fb9b73d
@TilakMaddy
Spike: Adjust for new lint rules introduced by clippy (#769)
6aae4b4
@TilakMaddy
Lower severity of Block.Timestamp Deadline detector (#767)
7331fe2
@TilakMaddy
Kill detector: uninitialized state variable (#770)
a19aa12
@TilakMaddy
Don't report uninitialized state variable when there is initializer…
f0c14b5 
… modifier (#771)
@TilakMaddy
Fix: Lower severity for Delegate Call Detector (#772)
ab2eecc
@TilakMaddy
Update .is_constructor -> .kind() == &FunctionKind::Constructor f…
1acd400 
…or broader version compatiblity (#773)
@TilakMaddy
Fix: Account for revert statements not just revert functions in requi…
6dfe3a1 
…re/revert in loop detector (#774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexroan alexroan Awaiting requested review from alexroan alexroan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TilakMaddy @Ritik-Agarwal50 @mgiagante