Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Improving Authentication Scanning Process #135

Open
MindPatch opened this issue May 26, 2023 · 1 comment
Open

Enhancement Request: Improving Authentication Scanning Process #135

MindPatch opened this issue May 26, 2023 · 1 comment
Labels
core-changes make changes for Lotus Core in Rust new-api
Milestone

Comments

@MindPatch
Copy link
Contributor

Currently, the usage of custom headers such as Cookies or X-API for authentication scanning falls short in effectively enhancing the process. To address this limitation, we propose the addition of additional functions to the input-handler script that can better control the authentication flow.

We suggest the inclusion of two specific functions to augment the authentication process:

  • Login Function: This function would facilitate the authentication by handling the login process. By integrating this function into the input-handler script, we can ensure that the scanner is authenticated before proceeding with the scanning activities.

  • Logout Check Function: This function would be responsible for verifying whether the scanner has been logged out or not. By periodically checking the authentication status, we can detect any unexpected logout events and take appropriate actions accordingly.

By implementing these additional functions, we aim to enhance the overall authentication scanning process, providing better control and ensuring the scanner's uninterrupted access to the necessary resources.

We welcome any feedback or suggestions regarding these proposed enhancements and are open to further discussions on how to improve the authentication scanning mechanism.

@MindPatch MindPatch added new-api core-changes make changes for Lotus Core in Rust labels May 26, 2023
@MindPatch MindPatch added this to the 0.6.0-beta milestone May 26, 2023
@MindPatch
Copy link
Contributor Author

UPDATE: Since Lotus is focusing on performance, instead of running the logout check function after every request, we can execute that function using the "--requests-limit" option. This option will cause Lotus to sleep and run the Lua function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-changes make changes for Lotus Core in Rust new-api
Projects
None yet
Development

No branches or pull requests

1 participant