Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] response shape refactor #147

Closed
3 tasks done
BeauBouchard opened this issue Aug 18, 2022 · 0 comments
Closed
3 tasks done

[BREAKING CHANGE] response shape refactor #147

BeauBouchard opened this issue Aug 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@BeauBouchard
Copy link
Member

BeauBouchard commented Aug 18, 2022

The previous response shape was intended for slack consumption with a command using an endpoint setup in the slack admin panel.

I would prefer to have the response shape change if there is a parameter and have that handled by middleware for the API.

I also want to add more data to the response for its eventual consumption on the weather page.

Because the API is being informally used I have some metrics indicating a few people may be using it for something still. I am going to try to version the API going forward after this change, however the URI will need to change to accommodate the middleware decisions above.

Acceptence Criteria

  • Fix the response shape to match the below examples
  • version design syntax for future outlined
  • middleware for response shape output outlined

Response Requirements

Symbol Library
⛅
🌤 
🌥 
🌦 
☁ 
🌧 
⛈ 
🌩 
☀ 
⚡ 
🌞 
❄ 
🌨 
☃ 
⛄
🌬
💨
🌪
🌫
🌈 
☔ 
💧 
💦 
🧣 
🌂 
☂ 
🔅 
🔆 
🥵 
🥶 
🧊 
ϟ
☀
☁ 
☂ 
☃ 
☄ 
☉ 
☼ 
☽ 
☾ 
♨ 
❄ 
❅ 
❆
@BeauBouchard BeauBouchard added the enhancement New feature or request label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant