Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples updates #1035

Merged
merged 11 commits into from
Sep 1, 2023
Merged

Samples updates #1035

merged 11 commits into from
Sep 1, 2023

Conversation

jshcodes
Copy link
Member

@jshcodes jshcodes commented Sep 1, 2023

Sample Updates

Updates the ProxyTool sample, and resolves some documentation issues.

  • Documentation
  • Code sample

Unit test coverage

COVERAGE TESTING NOT REQUIRED FOR SAMPLE SUBMISSIONS

Bandit analysis

[main]	INFO	running on Python 3.9.17

Run started:2023-09-01 00:26:53.533545

Test results:
	No issues identified.

Code scanned:
	Total lines of code: 12381
	Total lines skipped (#nosec): 2

Run metrics:
	Total issues (by severity):
		Undefined: 0
		Low: 0
		Medium: 0
		High: 0
	Total issues (by confidence):
		Undefined: 0
		Low: 0
		Medium: 0
		High: 0
Files skipped (0):

Issues resolved

  • Updated: Updates ProxyTool to check provided CID against current environment customer ID. Documentation updates.
    • samples/README.md
    • samples/proxytool/proxytool.py
    • samples/proxytool/README.md
  • Updated: MalQueryinator scope requirements documentation.
    • samples/malquery/README.md

carlosmmatos and others added 11 commits August 23, 2023 23:08
Add warning that this version is obsolete and no longer maintained.
Add comment about version being no longer maintained.
Latest version. 
Fixes #1018
No longer has version in filename.
Update filename in syntax examples.
Clarification about scope
Removed version number from output
@github-actions github-actions bot added documentation 📖 Improvements or additions to documentation pipeline CI/CD related code samples Functioning sample code to get you started labels Sep 1, 2023
@jshcodes jshcodes merged commit 2e2aa34 into main Sep 1, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code samples Functioning sample code to get you started documentation 📖 Improvements or additions to documentation pipeline CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants