From 08080986d4e976040a6ed6c2895b3f7c3ee0fdf5 Mon Sep 17 00:00:00 2001 From: Joshua Hiller Date: Mon, 30 Oct 2023 11:30:25 -0400 Subject: [PATCH] Add missing actions to validation. Closes #1059. --- CHANGELOG.md | 5 ++++- src/falconpy/firewall_policies.py | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 18bfbfbb6..2db70efb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,9 +49,12 @@ + Fixed: Error when trying to directly import falconpy module (no package installation). Closes #1056. - `_auth_object/_falcon_interface.py` - `_util/_functions.py` - - Thanks to @tsullivan06 for identifying and reporting this issue. 🙇 + - Thanks go out to @tsullivan06 for identifying and reporting this issue. 🙇 + Fixed: Legacy Uber Class is not logging Operation ID in debug logs. Closes #1057. - `api_complete/_legacy.py` ++ Fixed: Can not use `add-rule-group` and `remove-rule-group` actions with the __`performFirewallPoliciesAction`__ operation. Closes #1059. + - `firewall_policies.py` + - Thanks go out to @api-clobberer for identifying and reporting this issue. 🙇 --- diff --git a/src/falconpy/firewall_policies.py b/src/falconpy/firewall_policies.py index 4047609e8..7f11da473 100644 --- a/src/falconpy/firewall_policies.py +++ b/src/falconpy/firewall_policies.py @@ -164,7 +164,9 @@ def perform_action(self: object, body: dict = None, parameters: dict = None, **k Swagger URL https://assets.falcon.crowdstrike.com/support/api/swagger.html#/firewall-policies/performFirewallPoliciesAction """ - _allowed_actions = ['add-host-group', 'disable', 'enable', 'remove-host-group'] + _allowed_actions = ['add-host-group', 'disable', 'enable', + 'remove-host-group', 'add-rule-group', 'remove-rule-group' + ] operation_id = "performFirewallPoliciesAction" parameter_payload = args_to_params(parameters, kwargs, Endpoints, operation_id) action_name = parameter_payload.get("action_name", "Not Specified")