Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaleltConnect modal does not show up on mobile #51

Open
kstulgys opened this issue Dec 18, 2024 · 3 comments
Open

WaleltConnect modal does not show up on mobile #51

kstulgys opened this issue Dec 18, 2024 · 3 comments

Comments

@kstulgys
Copy link

kstulgys commented Dec 18, 2024

  • I'm submitting a ...
    [x] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary

I get supported wallets and rendering in react app (I do not want to use the default modal). Then connect wallet by providing wallet Id. Works fine for desktop but for mobile if I select WalletConnect - the modal (WallectConnect modal) does not show up.

// render wallets
let wallets = await sdk.getSupportedWallets();

// connect wallet
sdk.setWallet(id);
const { address } = await sdk.getAddress();
  • Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
@earrietadev
Copy link
Contributor

This is most likely an issue with your code/domain/walletconnect integration/etc so you will need to give more details (sharing your full code/integration or the public site where we can test it) in order to help, the wallet connect modal is working ok for mobile in sites like: app.fxdao.io, app.sorobandomains.org, mainnet.blend.capital, stellar.cables.finance, etc

@kstulgys
Copy link
Author

kstulgys commented Dec 18, 2024

Thank you for the reply. I can confirm it's vey likely the issue is on my end. On my website I'm actually initialising 2 walletconnect modals. One is with wagmi for evm chains and another is with stelar-wallets-kit. Most likely there is some clash between these 2 because if I initialise only stelar-wallets-kit walletconnect works just fine. Both works fine on desktop but on mobile works only wagmi unless wagmi is not initialised.

@earrietadev
Copy link
Contributor

If you are instantiating the walletconnect client twice then you will have a race problem between both. I suggest only starting the one that will be needed at a time (since evm and soroban are not compatible then the user is going to interact only when they are going to use the correct chain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants