Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start.sh creates an unusable path to java #13

Open
Goobaroo opened this issue Jun 4, 2022 · 0 comments
Open

start.sh creates an unusable path to java #13

Goobaroo opened this issue Jun 4, 2022 · 0 comments

Comments

@Goobaroo
Copy link

Goobaroo commented Jun 4, 2022

When using the serverinstaller on linux. (build 22.530.1936).

The start.sh script incorrectly adds a "./" to the path to both the JVM when chosen to install with the server

.//data/jre/jdk-17.0.2+8-jre/bin/java -javaagent:log4jfix/Log4jPatcher-1.0.0.jar -XX:+UseG1GC -XX:+UnlockExperimentalVMOptions -Xmx6144M -Xms4096M @user_jvm_args.txt @libraries/net/minecraftforge/forge/1.18.2-40.1.25/unix_args.txt nogui

If you skip the JVM install you get:
./java -javaagent:log4jfix/Log4jPatcher-1.0.0.jar -XX:+UseG1GC -XX:+UnlockExperimentalVMOptions -Xmx6144M -Xms4096M @user_jvm_args.txt @libraries/net/minecraftforge/forge/1.18.2-40.1.25/unix_args.txt nogui

I noticed that it is now deleting the run.sh that is provided by Forge. But you can retain it by using the --noscript flag which produces a usable run.sh/bat that you can use to start the server.

Seems related to this change here:

"./" + java.GetJavaPath(installPath) + " -javaagent:log4jfix/Log4jPatcher-1.0.0.jar " + launch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant