Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Rename the start script for 1.18+ packs #11

Open
Raidobw2 opened this issue May 27, 2022 · 1 comment
Open

Suggestion: Rename the start script for 1.18+ packs #11

Raidobw2 opened this issue May 27, 2022 · 1 comment

Comments

@Raidobw2
Copy link

Modpacks like Direwolf20 1.18 now have a run.bat script from the Forge install. That script is now used entirely to start the server and there is no more Forge jar directly in the root folder of the server. The start.bat script shipped by the server installer fails to find the jar, therefore it's never put in the script.

I would like to suggest implementing something where if run.bat is found, that run.bat script is renamed to start.bat.

This will standardize installers for our users and the change should be retroactively compatible with old packs.
People will also stop being confused about 2 batch scripts and see only one. I have it documented in the server procedure https://go.ftb.team/create-a-server for them already and point them towards it when that happens, but I think my suggestion could be better for users.

Everytime I mean batch script I also mean shell script,

Idea suggested by jikuja on the FTB Discord, which I agreed with, was a good idea!

Thanks for looking into it, if you need to reproduce it download Direwolf20 1.18 from the FTB site: https://feed-the-beast.com/modpack/95_ftb_presents_direwolf20_1_18/server-files, then try and run the start.bat script to start the server

@Raidobw2
Copy link
Author

Raidobw2 commented Jun 9, 2022

Hmm, oddly enough the Windows script has this fixed (thanks a lot!) but the Linux one does not :o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant