Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use itemRenderer.render instead of renderStatic in ValueBoxRenderer #7125

Open
wants to merge 1 commit into
base: mc1.20.1/dev
Choose a base branch
from
Open

use itemRenderer.render instead of renderStatic in ValueBoxRenderer #7125

wants to merge 1 commit into from

Conversation

MoePus
Copy link

@MoePus MoePus commented Nov 4, 2024

No description provided.

@IThundxr IThundxr added area: rendering Issue or PR is related to rendering pr flag: simple PR has minimal changes labels Nov 4, 2024
@TropheusJ
Copy link
Collaborator

why?

@MoePus
Copy link
Author

MoePus commented Nov 5, 2024

@MoePus
[use ](/Creators-of-Create/Create/pull/7125/commits/a5b073d9c645e8d09f8b943a6a5ea85d1ab0efb2)

The function itemRenderer.renderStatic calls itemRenderer.getModel which has already been called in our function then calls itemRenderer.render
So using itemRenderer.render can save a little performance

Refer #6674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: rendering Issue or PR is related to rendering pr flag: simple PR has minimal changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoePus @TropheusJ @IThundxr