Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop (mis)using pistachio_bub for all pistachio based boards #22

Open
Ham22 opened this issue Dec 5, 2016 · 2 comments
Open

Stop (mis)using pistachio_bub for all pistachio based boards #22

Ham22 opened this issue Dec 5, 2016 · 2 comments

Comments

@Ham22
Copy link
Member

Ham22 commented Dec 5, 2016

Pistachio was never added as a SoC and instead we added everything in the pistachio_bub board setup. This has meant as new boards have been added they have been hacked in based on the pistachio_bub config rather than based on the pistachio SoC.

It would be nice if we could spend some time fixing this once and for all otherwise the problem is just going to get worse.

@abhimanyuv1
Copy link

I don't think we should remove pistachio_bub completely as later we might add new board and may need new config. may be better to rename to more generic pistachio_common.h or just pistachio.h

@Ham22
Copy link
Member Author

Ham22 commented Mar 15, 2017

The aim isn't to remove pistachio bub. The issue is that u-boot is designed to let you add SoCs and then boards based on those SoCs so you have something nice like this:

+------------------------------+
|  marduk  |  beetle  |  bub   |
|------------------------------|
|           pistahcio          |
+------------------------------+

but instead we have no SoC definition and just a single board of pistachio bub which has had some other board support hacked into it by passing through different config options:

+--------------------------------------------------+
|  pistachio bub (with hacks for marduk and beetle |
+--------------------------------------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants